[turbofan] Avoid unnecessary (u)int32<->float64 changes in simplified lowering.

[turbofan] Avoid unnecessary (u)int32<->float64 changes in simplified lowering.

BUG=
R=bmeurer@chromium.org, titzer@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=25045

[Jarin, 2014-10-28 15:05:12]

jarin@chromium.org changed reviewers:
+ titzer@chromium.org

[Jarin, 2014-10-28 15:05:48]

Could you take a look, please?

[titzer, 2014-10-28 15:10:42]

Can we get some unit tests, either in test-simplified-lowering or mjsunit/asm/ ?

https://codereview.chromium.org/683873002/diff/1/src/compiler/simplified-lowe...
File src/compiler/simplified-lowering.cc (right):

https://codereview.chromium.org/683873002/diff/1/src/compiler/simplified-lowe...
src/compiler/simplified-lowering.cc:654: in_upper->Is(Type::Unsigned32()) ||
Something feels a little fishy here. What about making a similar looking case to
the one above like:

if (in_upper->Is(Type::Signed32())) {  // existing
...
} else if (in_upper->Is(Type::Unsigned32())) { // new
...
} else if ((in & kTypeMask) == kTypeUint32) { // existing
...

[Benedikt Meurer, 2014-10-30 07:29:26]

bmeurer@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Benedikt Meurer, 2014-10-30 07:29:26]

LGTM, tests would be nice ;-)

[Jarin, 2014-10-31 16:00:30]

On 2014/10/30 07:29:26, Benedikt Meurer wrote:
> LGTM, tests would be nice ;-)

Could you take a look at the test?

[titzer, 2014-10-31 16:26:35]

lgtm

[Jarin, 2014-10-31 19:53:36]

Committed patchset #4 (id:60001) manually as 25045 (presubmit successful).