Remove some of the instrumentation plumbing

cc: Remove some of the instrumentation plumbing

Code cleanup

Since rasterize_time, analysis_time and rasterized_pixel_count are
no longer used, they can be removed and as a result, a lot of
plumbing to push these stats around can also be removed.

R=vmpstr, ernstm, reveman

Committed: https://crrev.com/9b7f6d9839634f19cead07d91d1e3ea9dbfae139
Cr-Commit-Position: refs/heads/master@{#302684}

[hendrikw, 2014-10-30 17:31:32]

hendrikw@chromium.org changed reviewers:
+ ernstm@chromium.org, reveman@chromium.org, vmpstr@chromium.org

[hendrikw, 2014-10-30 17:33:00]

PTAL --- Please note requires https://codereview.chromium.org/689503002/ to
land.

[vmpstr, 2014-10-30 17:40:18]

Nice cleanup! lgtm (% others)

https://codereview.chromium.org/683863003/diff/1/tools/telemetry/telemetry/we...
File tools/telemetry/telemetry/web_perf/metrics/rendering_stats_unittest.py
(right):

https://codereview.chromium.org/683863003/diff/1/tools/telemetry/telemetry/we...
tools/telemetry/telemetry/web_perf/metrics/rendering_stats_unittest.py:143:
'rasterize_time': mock_timer.Advance(5, 10) / 1000.0,
this too?

[ernstm, 2014-10-30 20:18:48]

Why not remove record_time, recorded_pixel_count, paint_time and
painted_pixel_count as well? This would allow you to remove the entire
MainThreadRenderingStats and merge ImplThreadRenderingStats right into
RenderingStats.

https://codereview.chromium.org/683863003/diff/1/cc/resources/tile_manager.cc
File cc/resources/tile_manager.cc (left):

https://codereview.chromium.org/683863003/diff/1/cc/resources/tile_manager.cc...
cc/resources/tile_manager.cc:133: LOCAL_HISTOGRAM_CUSTOM_COUNTS(
Does anybody know what this histogram is?

[hendrikw, 2014-10-30 20:42:03]

On 2014/10/30 20:18:48, ernstm wrote:
> Why not remove record_time, recorded_pixel_count, paint_time and
> painted_pixel_count as well? This would allow you to remove the entire
> MainThreadRenderingStats and merge ImplThreadRenderingStats right into
> RenderingStats.
> 
> https://codereview.chromium.org/683863003/diff/1/cc/resources/tile_manager.cc
> File cc/resources/tile_manager.cc (left):
> 
>
https://codereview.chromium.org/683863003/diff/1/cc/resources/tile_manager.cc...
> cc/resources/tile_manager.cc:133: LOCAL_HISTOGRAM_CUSTOM_COUNTS(
> Does anybody know what this histogram is?

The histogram isn't used in uma, so it's internal only, I'm not sure who, if
anyone, is using it.

I agree that we should remove the other variables too, would you mind if I did
this in a followup patch?

[ernstm, 2014-10-30 20:46:13]

>
https://codereview.chromium.org/683863003/diff/1/cc/resources/tile_manager.cc...
> > cc/resources/tile_manager.cc:133: LOCAL_HISTOGRAM_CUSTOM_COUNTS(
> > Does anybody know what this histogram is?
> 
> The histogram isn't used in uma, so it's internal only, I'm not sure who, if
> anyone, is using it.
> 
> I agree that we should remove the other variables too, would you mind if I did
> this in a followup patch?

I'm not aware of any users of this histogram either. I don't even know how to
access the collected data if it's not in UMA. Let's remove it.

Follow up patch for the paint* and record* data is fine.

LGTM

[hendrikw, 2014-10-30 20:56:59]

address review comments: ptal, thanks!

[ernstm, 2014-10-30 21:13:34]

On 2014/10/30 20:56:59, Hendrik wrote:
> address review comments: ptal, thanks!

updated patch missing?

[hendrikw, 2014-10-30 21:15:34]

Not enough caffeine in my system yet.  Here it is (I addressed vmpster's
comment)

[ernstm, 2014-10-30 21:59:21]

On 2014/10/30 21:15:34, Hendrik wrote:
> Not enough caffeine in my system yet.  Here it is (I addressed vmpster's
> comment)

looks good.

[reveman, 2014-10-30 23:35:02]

awesomelgtm

[hendrikw, 2014-11-04 20:09:11]

The CQ bit was checked by hendrikw@chromium.org

[commit-bot: I haz the power, 2014-11-04 20:10:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/683863003/40001

[commit-bot: I haz the power, 2014-11-04 22:28:53]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-11-04 22:29:29]

Patchset 3 (id:??) landed as
https://crrev.com/9b7f6d9839634f19cead07d91d1e3ea9dbfae139
Cr-Commit-Position: refs/heads/master@{#302684}