Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 683853006: Rename GalaxyNexus GM and SkImage expectations for GalaxyS4, remove NexusS (Closed)

Created:
6 years, 1 month ago by borenet
Modified:
6 years, 1 month ago
Reviewers:
hcm, djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Rename GalaxyNexus GM and SkImage expectations for GalaxyS4, remove NexusS GMs will surely need rebaselining. BUG=skia:3032 Committed: https://skia.googlesource.com/skia/+/067c065a6664d7fb5bb1d41af9e8641e5350fccc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-4 lines, -35048 lines) Patch
D expectations/gm/Test-Android-GalaxyNexus-SGX540-Arm7-Debug/expected-results.json View 1 chunk +0 lines, -8167 lines 0 comments Download
D expectations/gm/Test-Android-GalaxyNexus-SGX540-Arm7-Release/expected-results.json View 1 chunk +0 lines, -8159 lines 0 comments Download
A + expectations/gm/Test-Android-GalaxyS4-SGX544-Arm7-Debug/expected-results.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + expectations/gm/Test-Android-GalaxyS4-SGX544-Arm7-Release/expected-results.json View 0 chunks +-1 lines, --1 lines 0 comments Download
D expectations/gm/Test-Android-NexusS-SGX540-Arm7-Debug/expected-results.json View 1 chunk +0 lines, -7795 lines 0 comments Download
D expectations/gm/Test-Android-NexusS-SGX540-Arm7-Release/expected-results.json View 1 chunk +0 lines, -7795 lines 0 comments Download
D expectations/skimage/Test-Android-GalaxyNexus-SGX540-Arm7-Debug/expected-results.json View 1 chunk +0 lines, -784 lines 0 comments Download
D expectations/skimage/Test-Android-GalaxyNexus-SGX540-Arm7-Release/expected-results.json View 1 chunk +0 lines, -784 lines 0 comments Download
A + expectations/skimage/Test-Android-GalaxyS4-SGX544-Arm7-Debug/expected-results.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + expectations/skimage/Test-Android-GalaxyS4-SGX544-Arm7-Release/expected-results.json View 0 chunks +-1 lines, --1 lines 0 comments Download
D expectations/skimage/Test-Android-NexusS-SGX540-Arm7-Debug/expected-results.json View 1 chunk +0 lines, -784 lines 0 comments Download
D expectations/skimage/Test-Android-NexusS-SGX540-Arm7-Release/expected-results.json View 1 chunk +0 lines, -784 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
borenet
6 years, 1 month ago (2014-10-28 20:01:35 UTC) #2
djsollen
lgtm
6 years, 1 month ago (2014-10-29 13:10:03 UTC) #3
borenet
+Heather for FYI. This will surely cause CompareGMs failures on GalaxyS4 bots until we rebaseline.
6 years, 1 month ago (2014-10-29 13:12:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/683853006/1
6 years, 1 month ago (2014-10-29 13:13:12 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-10-29 13:21:32 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 067c065a6664d7fb5bb1d41af9e8641e5350fccc

Powered by Google App Engine
This is Rietveld 408576698