Fewer focusable items in chrome://settings/searchEngines

chrome/browser/resources/options/search_engine_manager_engine_list.js

Index: chrome/browser/resources/options/search_engine_manager_engine_list.js
diff --git a/chrome/browser/resources/options/search_engine_manager_engine_list.js b/chrome/browser/resources/options/search_engine_manager_engine_list.js
index 2076f26b920899268f59b3763e01085081ea7994..5136b660785e4f79dda54d9056f95a94f806b070 100644
--- a/chrome/browser/resources/options/search_engine_manager_engine_list.js
+++ b/chrome/browser/resources/options/search_engine_manager_engine_list.js
@@ -111,7 +111,7 @@ cr.define('options.search_engines', function() {
         this.classList.add('default');
 
       this.deletable = engine.canBeRemoved;
-      this.closeButtonElement.tabIndex = 0;

[Dan Beam, 2014/10/30 01:45:49]

this took immediate effect

+      this.closeButtonFocusAllowed = true;

[Dan Beam, 2014/10/30 01:45:49]

when does this change behavior?  why can't we make this an ES5 setter and update
when it changes?

[bondd, 2014/10/30 15:00:04]

closeButtonFocusAllowed indicates whether the button can *ever* have keyboard
focus; tabIndex itself is modified when the list item gains/loses lead status
and when the list itself gains/loses focus (see calls to setCloseButtonFocusable
in inline_editable_list.js).

closeButtonFocusAllowed is set on init and is not intended to change after that.
Value depends on list type, e.g. "Manage search engines" has it and other lists
don't (but may in the future). I can't see closeButtonFocusAllowed ever changing
dynamically while the list is in use.

Making it take effect immediately could be tricky because it's not directly
coupled to tabIndex, and the code to do that will be dead code anyway since
there is no reason to change closeButtonFocusAllowed after the list is
initialized.

The simplest solution might be to write a comment on the closeButtonFocusAllowed
variable declaration making it more clear what it does, and that it is only to
be set on init. I could also rename it to be more descriptive, like
closeButtonFocusEverAllowed (or whatever you suggest).

 
       // Construct the name column.
       var nameColEl = this.ownerDocument.createElement('div');