Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: chrome/browser/ui/webui/options/autofill_options_browsertest.js

Issue 683813004: Fewer focusable items in chrome://settings/searchEngines (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add comment about weird behavior in autofill_options_browsertest.js Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/options_test_resources.grd ('k') | chrome/browser_tests.isolate » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/options/autofill_options_browsertest.js
diff --git a/chrome/browser/ui/webui/options/autofill_options_browsertest.js b/chrome/browser/ui/webui/options/autofill_options_browsertest.js
index 43821b205a016ea6bd8a9095aa34ce21ef59214f..6efa92bd7fa9a380b06fedc4e2702843561eed00 100644
--- a/chrome/browser/ui/webui/options/autofill_options_browsertest.js
+++ b/chrome/browser/ui/webui/options/autofill_options_browsertest.js
@@ -195,7 +195,20 @@ TEST_F('AutofillEditAddressAsyncWebUITest',
input.focus();
document.execCommand('insertText', false, '111-222-333');
assertEquals('111-222-333', input.value);
- input.blur();
+ // TODO(bondd, dbeam): The way that focus/blur interact with the testing
+ // system is rather confusing. The next line was originally
+ // input.blur();
+ // but the test would time out when run as a single test locally (i.e.
+ // --gtest_filter=<test_name>), and complete successfully when other tests
+ // were run first (e.g. by the trybot, or locally with a wider
+ // gtest_filter). Changing the line to
+ // phoneList.blur();
+ // makes the result more deterministic when the test is run by itself.
+ //
+ // phoneList.blur() calls cr.ui.List.handleElementBlur_, which triggers
+ // InlineEditableItemList.handleListFocusChange_, which sends the
+ // 'commitedit' event.
+ phoneList.blur();
phoneList.doneValidating().then(testDone);
});
});
« no previous file with comments | « chrome/browser/resources/options_test_resources.grd ('k') | chrome/browser_tests.isolate » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698