Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4737)

Unified Diff: chrome/browser/resources/options/deletable_item_list.js

Issue 683813004: Fewer focusable items in chrome://settings/searchEngines (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add comment about weird behavior in autofill_options_browsertest.js Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/deletable_item_list.js
diff --git a/chrome/browser/resources/options/deletable_item_list.js b/chrome/browser/resources/options/deletable_item_list.js
index 0d52ff07bab0d275472f3c7a551460cf0caee9d6..d4efea8f3bb4b6a492cdf1d8c0776efa669cf8b4 100644
--- a/chrome/browser/resources/options/deletable_item_list.js
+++ b/chrome/browser/resources/options/deletable_item_list.js
@@ -38,6 +38,14 @@ cr.define('options', function() {
*/
deletable_: true,
+ /**
+ * Whether or not the close button can ever be navigated to using the
+ * keyboard.
+ * @type {boolean}
+ * @protected
+ */
+ closeButtonFocusAllowed: false,
+
/** @override */
decorate: function() {
ListItem.prototype.decorate.call(this);
@@ -57,7 +65,7 @@ cr.define('options', function() {
this.closeButtonElement_.addEventListener('mouseup',
this.handleMouseDownUpOnClose_);
this.closeButtonElement_.addEventListener('focus',
- this.handleFocus_.bind(this));
+ this.handleFocus.bind(this));
this.closeButtonElement_.tabIndex = -1;
this.closeButtonElement_.title =
loadTimeData.getString('deletableItemDeleteButtonTitle');
@@ -94,9 +102,9 @@ cr.define('options', function() {
/**
* Called when a focusable child element receives focus. Selects this item
* in the list selection model.
- * @private
+ * @protected
*/
- handleFocus_: function() {
+ handleFocus: function() {
// This handler is also fired when the child receives focus as a result of
// the item getting selected by the customized mouse/keyboard handling in
// SelectionController. Take care not to destroy a potential multiple
« no previous file with comments | « chrome/browser/resources/options/autofill_options_list.js ('k') | chrome/browser/resources/options/inline_editable_list.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698