Fewer focusable items in chrome://settings/searchEngines

chrome/browser/ui/webui/options/autofill_options_browsertest.js

Index: chrome/browser/ui/webui/options/autofill_options_browsertest.js
diff --git a/chrome/browser/ui/webui/options/autofill_options_browsertest.js b/chrome/browser/ui/webui/options/autofill_options_browsertest.js
index 43821b205a016ea6bd8a9095aa34ce21ef59214f..3c0d482472b621d27faf315ceed240006dd53432 100644
--- a/chrome/browser/ui/webui/options/autofill_options_browsertest.js
+++ b/chrome/browser/ui/webui/options/autofill_options_browsertest.js
@@ -195,7 +195,7 @@ TEST_F('AutofillEditAddressAsyncWebUITest',
     input.focus();
     document.execCommand('insertText', false, '111-222-333');
     assertEquals('111-222-333', input.value);
-    input.blur();
+    phoneList.blur();

[bondd, 2014/11/11 23:43:24]

The way that InlineEditableItem triggers validation changed and it broke this
test.
"input->phoneList" fixes the test.

The purpose of this test is to verify that validation is triggered when text is
changed. Validation was previously triggered when the InlineEditableItem was
blurred. Now it is triggered when the lead item changes or the entire list
gains/loses focus. The InlineEditableItem cannot be blurred without one of those
two other events happening (as far as I know). I changed the test to blur the
entire list rather than just the item.

I considered adding an additional test for changing the lead item, but the main
purpose of this existing test is to verify the validation-specific code in
autofill_options_list.js, not to verify details of inline_editable_item.js. So I
think this solution is reasonable as-is.

[Dan Beam, 2014/11/11 23:59:29]

this does nothing afaict: http://jsfiddle.net/6pwo54co/
what breaks and how was this supposed to fix?

[bondd, 2014/11/12 00:43:56]

What breaks: doneValidating() never fires, so test times out.

How this fixes it: removes focus from list.
InlineEditableItemList.handleListFocusChange_ gets called and causes
"commitedit" event, resulting in validation happening.

[Dan Beam, 2014/11/12 01:02:28]

that doesn't happen because you can't blur() an element that doesn't have focus.
 what actually happens is that a synthetic 'blur' event triggers this code:
https://code.google.com/p/chromium/codesearch#chromium/src/ui/webui/resources...

[Dan Beam, 2014/11/12 02:23:11]

nothing is real, this code makes no sense.  lgtm

     phoneList.doneValidating().then(testDone);
   });
 });