Fewer focusable items in chrome://settings/searchEngines

chrome/test/data/webui/webui_resource_browsertest.cc

Index: chrome/test/data/webui/webui_resource_browsertest.cc
diff --git a/chrome/test/data/webui/webui_resource_browsertest.cc b/chrome/test/data/webui/webui_resource_browsertest.cc
index b3250751c4e44e2a301f08ad6aebd3a0688a2354..0aac6b2b4e5ac46e58d0eced4ed1c64f8b1af6f5 100644
--- a/chrome/test/data/webui/webui_resource_browsertest.cc
+++ b/chrome/test/data/webui/webui_resource_browsertest.cc
@@ -106,6 +106,22 @@ IN_PROC_BROWSER_TEST_F(WebUIResourceBrowserTest, ListSingleSelectionModelTest) {
       "list_single_selection_model_test.html")));
 }
 
+IN_PROC_BROWSER_TEST_F(WebUIResourceBrowserTest, InlineEditableListTest) {
+  AddLibrary(IDR_WEBUI_JS_CR);
+  AddLibrary(IDR_WEBUI_JS_CR_EVENT_TARGET);
+  AddLibrary(IDR_WEBUI_JS_CR_UI);
+  AddLibrary(IDR_WEBUI_JS_CR_UI_ARRAY_DATA_MODEL);
+  AddLibrary(IDR_WEBUI_JS_CR_UI_LIST_ITEM);
+  AddLibrary(IDR_WEBUI_JS_CR_UI_LIST_SELECTION_CONTROLLER);
+  AddLibrary(IDR_WEBUI_JS_CR_UI_LIST_SELECTION_MODEL);
+  AddLibrary(IDR_WEBUI_JS_CR_UI_LIST);
+  AddLibrary(IDR_WEBUI_JS_LOAD_TIME_DATA);
+  AddLibrary(IDR_OPTIONS_DELETABLE_ITEM_LIST);
+  AddLibrary(IDR_OPTIONS_INLINE_EDITABLE_LIST);

[bondd, 2014/11/06 02:45:41]

deletable_item_list.js and inline_editable_list.js are in
chrome/browser/resources/options/. Base class list stuff is in
ui/webui/resources/js/cr/ui/. Very different locations. Is it okay to add the
inline_editable_list tests in here, or should I make an
options_resource_browsertest.cc (or similar) somewhere?

[Dan Beam, 2014/11/06 02:56:13]

adding the tests in here and pre-loading all of ui/webui stuff is fine.

why can't you just include chrome/browser/resources stuff via a local <script
src="../../../browser/resources/options/..."> like I mentioned before?

[bondd, 2014/11/06 03:02:36]

I tried that. The AddLibrary libs are added after the .html is loaded, so
<script src ="../../../browser/resources/options/..."> fails because all this
AddLibrary stuff (cr, ui, lists, etc.) isn't loaded yet.  I tried to do a
delayed load of the browser/resources/options/ scripts in
inline_editable_list_test.html, but the scripts load asynchronously and so
aren't ready for immediate use. Any recommendations?

[Dan Beam, 2014/11/07 05:38:40]

do what we talked about wrt making a test-only .grd for this kind of thing
that's in chrome/browser/resources/ somewhere

+  RunTest(base::FilePath(FILE_PATH_LITERAL(
+      "inline_editable_list_test.html")));
+}
+
 IN_PROC_BROWSER_TEST_F(WebUIResourceBrowserTest, MenuTest) {
   AddLibrary(IDR_WEBUI_JS_ASSERT);
   AddLibrary(IDR_WEBUI_JS_CR);