Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3030)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/test/data/webui/inline_editable_list_test.html

Issue 683813004: Fewer focusable items in chrome://settings/searchEngines (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add browser test. WIP, uploaded for discussion Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/options/search_engine_manager_engine_list.js ('k') | chrome/test/data/webui/webui_resource_browsertest.cc » ('j') | chrome/test/data/webui/webui_resource_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/inline_editable_list_test.html
diff --git a/chrome/test/data/webui/inline_editable_list_test.html b/chrome/test/data/webui/inline_editable_list_test.html
new file mode 100644
index 0000000000000000000000000000000000000000..39e63d500a6bd210abcd0a66ce30b0f1a568feee
--- /dev/null
+++ b/chrome/test/data/webui/inline_editable_list_test.html
@@ -0,0 +1,153 @@
+<!DOCTYPE html>
+<html>
+<body>
+
+<script>
+
+function setUp() {
bondd 2014/11/06 02:45:41 Need to do things in setUp for reason given in web
Dan Beam 2014/11/07 19:43:59 Acknowledged.
+ loadTimeData.data = {
bondd 2014/11/06 02:45:41 This seems like a total hack. Without this I get t
Dan Beam 2014/11/07 19:43:59 Acknowledged.
+ 'deletableItemDeleteButtonTitle': 'test_deletable_button_title'
+ };
+
+ cr.define('options', function() {
+ /** @const */ var InlineEditableItemList = options.InlineEditableItemList;
+ /** @const */ var InlineEditableItem = options.InlineEditableItem;
+
+ /**
+ * Creates a test list item.
+ * @param {string} name This item's name.
+ * @constructor
+ * @extends {options.InlineEditableItem}
+ */
+ function TestItem(name) {
Dan Beam 2014/11/06 02:54:08 why do we need this class?
bondd 2014/11/07 17:36:14 This is the pattern followed by all classes that u
Dan Beam 2014/11/07 19:43:58 ok but doesn't creating different types of items m
bondd 2014/11/07 20:13:25 Nope, I think it's fine. The list is populated wit
+ var el = cr.doc.createElement('div');
+ el.name_ = name;
+ TestItem.decorate(el);
+ return el;
+ }
+
+ /**
+ * Decorates an element as a test list item.
+ * @param {!HTMLElement} el The element to decorate.
+ */
+ TestItem.decorate = function(el) {
+ el.__proto__ = TestItem.prototype;
+ el.decorate();
+ };
+
+ TestItem.prototype = {
+ __proto__: InlineEditableItem.prototype,
+
+ /**
+ * Item name. Used to set the item's text fields.
+ * @type {string}
+ * @private
+ */
+ name_: null,
+
+ /** @override */
+ decorate: function() {
+ InlineEditableItem.prototype.decorate.call(this);
+
+ var fieldEl = this.createEditableTextCell(this.name_);
+ this.contentElement.appendChild(fieldEl);
+
+ fieldEl = this.createEditableTextCell(this.name_ + '_two');
+ this.contentElement.appendChild(fieldEl);
+ },
+ };
+
+ /**
+ * @constructor
+ * @extends {options.InlineEditableItemList}
+ */
+ var TestItemList = cr.ui.define('list');
Dan Beam 2014/11/06 02:54:08 and this one?
bondd 2014/11/07 17:36:14 See above comment.
+
+ TestItemList.prototype = {
+ __proto__: InlineEditableItemList.prototype,
+
+ /**
+ * @override
+ * @param {string} name
+ */
+ createItem: function(name) {
+ return new TestItem(name);
+ },
+
+ /**
+ * @param {!Element} el
+ * @return {boolean} True if |el| or any of its children are focusable.
+ * @private
+ */
+ hasFocusableElement_: function(el) {
+ return el.querySelectorAll('[tabindex="0"]').length > 0;
+ },
+
+ /**
+ * @param {number} itemIndex
+ * @return {boolean} True if item at |itemIndex| has a focusable element
+ * and no other items have focusable elements.
+ */
+ hasExactlyOneItemFocusable: function(itemIndex) {
+ var length = this.items.length;
+ for(var i = 0; i < length; ++i) {
+ if (this.hasFocusableElement_(this.items[i]) != (i == itemIndex))
+ return false;
+ }
+ return true;
+ },
+ };
+
+ // Export.
+ return {
+ TestItemList: TestItemList
+ };
+
+ })
+}
+
+/**
+ * @param {!EventTarget} target Where to send the event.
+ * @param {!string} keyIdentifier Which key to send.
+ */
+function sendKeyDownEvent(target, keyIdentifier) {
+ var event = document.createEvent('KeyboardEvent');
+ event.initKeyboardEvent('keydown', true, true, window, keyIdentifier);
+ assertEquals(keyIdentifier, event.keyIdentifier);
+ target.dispatchEvent(event);
+}
+
+/**
+ * Test that exactly one item in the list is focusable after navigating the
+ * list using up and down arrow keys.
+ */
+function testUpDownFocus() {
+ var list = document.createElement('ul');
+ list.style.position = 'absolute';
+ list.style.width = '800px';
+ list.style.height = '800px';
+ options.TestItemList.decorate(list);
+ document.body.appendChild(list);
+
+ var model = new cr.ui.ArrayDataModel(['itemA', 'itemB', 'itemC']);
+ list.dataModel = model;
+ list.selectionModel.setIndexSelected(0, true);
+ list.selectionModel.leadIndex = 0;
+
+ assertTrue(list.hasExactlyOneItemFocusable(0));
+ sendKeyDownEvent(list, 'Down');
+ assertTrue(list.hasExactlyOneItemFocusable(1));
+ sendKeyDownEvent(list, 'Down');
+ assertTrue(list.hasExactlyOneItemFocusable(2));
+ sendKeyDownEvent(list, 'Up');
+ assertTrue(list.hasExactlyOneItemFocusable(1));
+ sendKeyDownEvent(list, 'Up');
+ assertTrue(list.hasExactlyOneItemFocusable(0));
+ sendKeyDownEvent(list, 'Down');
+ assertTrue(list.hasExactlyOneItemFocusable(1));
+}
+
+</script>
+
+</body>
+</html>
« no previous file with comments | « chrome/browser/resources/options/search_engine_manager_engine_list.js ('k') | chrome/test/data/webui/webui_resource_browsertest.cc » ('j') | chrome/test/data/webui/webui_resource_browsertest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698