chrome/browser/resources/options/search_engine_manager_engine_list.js - Issue 683813004: Fewer focusable items in chrome://settings/searchEngines

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/search_engine_manager_engine_list.js

Issue 683813004: Fewer focusable items in chrome://settings/searchEngines (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add browser test. WIP, uploaded for discussion Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/options/inline_editable_list.js ('k') | chrome/test/data/webui/inline_editable_list_test.html » ('j') | chrome/test/data/webui/inline_editable_list_test.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/search_engine_manager_engine_list.js

diff --git a/chrome/browser/resources/options/search_engine_manager_engine_list.js b/chrome/browser/resources/options/search_engine_manager_engine_list.js

index 2076f26b920899268f59b3763e01085081ea7994..5136b660785e4f79dda54d9056f95a94f806b070 100644

--- a/chrome/browser/resources/options/search_engine_manager_engine_list.js

+++ b/chrome/browser/resources/options/search_engine_manager_engine_list.js

@@ -111,7 +111,7 @@ cr.define('options.search_engines', function() {

this.classList.add('default');

this.deletable = engine.canBeRemoved;

- this.closeButtonElement.tabIndex = 0;

+ this.closeButtonFocusAllowed = true;

// Construct the name column.

var nameColEl = this.ownerDocument.createElement('div');