Fewer focusable items in chrome://settings/searchEngines

chrome/browser/resources/options/deletable_item_list.js

Index: chrome/browser/resources/options/deletable_item_list.js
diff --git a/chrome/browser/resources/options/deletable_item_list.js b/chrome/browser/resources/options/deletable_item_list.js
index 0d52ff07bab0d275472f3c7a551460cf0caee9d6..60da4af9c0be3b37a5c8277ff29bee8634f5089d 100644
--- a/chrome/browser/resources/options/deletable_item_list.js
+++ b/chrome/browser/resources/options/deletable_item_list.js
@@ -38,6 +38,13 @@ cr.define('options', function() {
      */
     deletable_: true,
 
+    /**
+     * Whether or not the close button can ever be navigated to using the
+     * keyboard.
+     * @type {boolean}

[Dan Beam, 2014/10/29 01:37:12]

@protected

[bondd, 2014/10/29 17:19:07]

Done.

+     */
+    closeButtonFocusAllowed: false,
+
     /** @override */
     decorate: function() {
       ListItem.prototype.decorate.call(this);
@@ -57,7 +64,7 @@ cr.define('options', function() {
       this.closeButtonElement_.addEventListener('mouseup',
                                                 this.handleMouseDownUpOnClose_);
       this.closeButtonElement_.addEventListener('focus',
-                                                this.handleFocus_.bind(this));
+                                                this.handleFocus.bind(this));
       this.closeButtonElement_.tabIndex = -1;
       this.closeButtonElement_.title =
           loadTimeData.getString('deletableItemDeleteButtonTitle');
@@ -94,9 +101,9 @@ cr.define('options', function() {
     /**
      * Called when a focusable child element receives focus. Selects this item
      * in the list selection model.
-     * @private
+     * @protected
      */
-    handleFocus_: function() {
+    handleFocus: function() {

[bondd, 2014/10/28 22:29:57]

Made this protected because existing code in inline_editable_list.js was already
using it that way.

       // This handler is also fired when the child receives focus as a result of
       // the item getting selected by the customized mouse/keyboard handling in
       // SelectionController. Take care not to destroy a potential multiple