Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Side by Side Diff: chrome/browser/resources/options/search_engine_manager_engine_list.js

Issue 683813004: Fewer focusable items in chrome://settings/searchEngines (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorporate reviewer comments from dbeam@ Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @typedef {{canBeDefault: boolean, 6 * @typedef {{canBeDefault: boolean,
7 * canBeEdited: boolean, 7 * canBeEdited: boolean,
8 * canBeRemoved: boolean, 8 * canBeRemoved: boolean,
9 * default: boolean, 9 * default: boolean,
10 * displayName: string, 10 * displayName: string,
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
104 engine.keyword = ''; 104 engine.keyword = '';
105 engine.url = ''; 105 engine.url = '';
106 } 106 }
107 107
108 this.currentlyValid_ = !this.isPlaceholder; 108 this.currentlyValid_ = !this.isPlaceholder;
109 109
110 if (engine.default) 110 if (engine.default)
111 this.classList.add('default'); 111 this.classList.add('default');
112 112
113 this.deletable = engine.canBeRemoved; 113 this.deletable = engine.canBeRemoved;
114 this.closeButtonElement.tabIndex = 0; 114 this.closeButtonFocusAllowed = true;
115 115
116 // Construct the name column. 116 // Construct the name column.
117 var nameColEl = this.ownerDocument.createElement('div'); 117 var nameColEl = this.ownerDocument.createElement('div');
118 nameColEl.className = 'name-column'; 118 nameColEl.className = 'name-column';
119 nameColEl.classList.add('weakrtl'); 119 nameColEl.classList.add('weakrtl');
120 this.contentElement.appendChild(nameColEl); 120 this.contentElement.appendChild(nameColEl);
121 121
122 // Add the favicon. 122 // Add the favicon.
123 var faviconDivEl = this.ownerDocument.createElement('div'); 123 var faviconDivEl = this.ownerDocument.createElement('div');
124 faviconDivEl.className = 'favicon'; 124 faviconDivEl.className = 'favicon';
(...skipping 241 matching lines...) Expand 10 before | Expand all | Expand 10 after
366 }, 366 },
367 }; 367 };
368 368
369 // Export 369 // Export
370 return { 370 return {
371 SearchEngineList: SearchEngineList 371 SearchEngineList: SearchEngineList
372 }; 372 };
373 373
374 }); 374 });
375 375
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698