sky/engine/core/rendering/shapes/ShapeOutsideInfo.h - Issue 683803006: Remove all writing mode function arguments and remove writing mode from RenderStyle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/rendering/shapes/ShapeOutsideInfo.h

Issue 683803006: Remove all writing mode function arguments and remove writing mode from RenderStyle. (Closed) Base URL: git@github.com:domokit/mojo.git@writingmode

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sky/engine/core/rendering/shapes/ShapeOutsideInfo.h

diff --git a/sky/engine/core/rendering/shapes/ShapeOutsideInfo.h b/sky/engine/core/rendering/shapes/ShapeOutsideInfo.h

index 1baea2527ea5f348d440d3e2c1c14e978ddd2165..b5b6e296442ba975a6bb8727739a4b3f64e04472 100644

--- a/sky/engine/core/rendering/shapes/ShapeOutsideInfo.h

+++ b/sky/engine/core/rendering/shapes/ShapeOutsideInfo.h

@@ -123,7 +123,7 @@ protected:

{ }

private:

- PassOwnPtr<Shape> createShapeForImage(StyleImage*, float shapeImageThreshold, WritingMode, float margin) const;

+ PassOwnPtr<Shape> createShapeForImage(StyleImage*, float shapeImageThreshold, float margin) const;

LayoutUnit logicalTopOffset() const;

LayoutUnit logicalLeftOffset() const;

« no previous file with comments | « sky/engine/core/rendering/shapes/Shape.cpp ('k') | sky/engine/core/rendering/shapes/ShapeOutsideInfo.cpp » ('j') | no next file with comments »