Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: sky/engine/core/rendering/RenderGrid.cpp

Issue 683803006: Remove all writing mode function arguments and remove writing mode from RenderStyle. (Closed) Base URL: git@github.com:domokit/mojo.git@writingmode
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/rendering/RenderBox.h ('k') | sky/engine/core/rendering/shapes/Shape.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/rendering/RenderGrid.cpp
diff --git a/sky/engine/core/rendering/RenderGrid.cpp b/sky/engine/core/rendering/RenderGrid.cpp
index caa8192976b0e774980a3859705617c305c8fe67..930b3d4d791f6ab4d6b2639715c836700fea4730 100644
--- a/sky/engine/core/rendering/RenderGrid.cpp
+++ b/sky/engine/core/rendering/RenderGrid.cpp
@@ -1296,26 +1296,8 @@ LayoutUnit RenderGrid::rowPositionForChild(const RenderBox* child) const
switch (alignSelf) {
case ItemPositionSelfStart:
- // If orthogonal writing-modes, this computes to 'Start'.
- // FIXME: grid track sizing and positioning does not support orthogonal modes yet.
- if (hasOrthogonalWritingMode)
- return startOfRowForChild(child);
-
- // self-start is based on the child's block axis direction. That's why we need to check against the grid container's block flow.
- if (child->style()->writingMode() != style()->writingMode())
- return endOfRowForChild(child);
-
return startOfRowForChild(child);
case ItemPositionSelfEnd:
- // If orthogonal writing-modes, this computes to 'End'.
- // FIXME: grid track sizing and positioning does not support orthogonal modes yet.
- if (hasOrthogonalWritingMode)
- return endOfRowForChild(child);
-
- // self-end is based on the child's block axis direction. That's why we need to check against the grid container's block flow.
- if (child->style()->writingMode() != style()->writingMode())
- return startOfRowForChild(child);
-
return endOfRowForChild(child);
case ItemPositionLeft:
« no previous file with comments | « sky/engine/core/rendering/RenderBox.h ('k') | sky/engine/core/rendering/shapes/Shape.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698