adds a signal, fixes a crash, adds syslogging, and marshals disks to d-bus

Bunch o' small changes in this CL

1. Fixes the makefile so it can deal with header autogeneration. Thanks Scott!
2. Fixes a crash udev-device.cc
3. Adds a simple test runner, no tests yet though. 
4. Adds a signal to the d-bus API.
5. Marshals the disks type to the d-bus wire format. 
6. Logs to the syslog and optionally stderr

Change-Id: Ifc3e9cfb22d5dbd3cb9406a94eb41d5b2c522e52

BUG=13698
TEST=Ran platform_CrosDisksDBus on a VM.

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=a153825

[Ben Chan, 2011-04-13 15:11:47]

http://codereview.chromium.org/6838011/diff/1011/cros-disks.conf
File cros-disks.conf (right):

http://codereview.chromium.org/6838011/diff/1011/cros-disks.conf#newcode7
cros-disks.conf:7: env CROS_DISKS_LOG_FILE=/var/log/crosdisks.log
How about naming it as cros-disks.log for consistency?

http://codereview.chromium.org/6838011/diff/1011/cros-disks.conf#newcode20
cros-disks.conf:20: chmod 0755 "${CROS_DISKS_LOG_FILE}"
Should the log file permission be 0644?

And should the log directory permission be set?

http://codereview.chromium.org/6838011/diff/1011/disk.cc
File disk.cc (right):

http://codereview.chromium.org/6838011/diff/1011/disk.cc#newcode41
disk.cc:41:
disk[kDeviceMountPaths].writer().append_string(mount_path().c_str());
According to
http://hal.freedesktop.org/docs/DeviceKit-disks/Device.html#Device:device-mou...,
DeviceMountPaths is a list of paths in the root namespace where the root of the
device is mounted. Should we pass a delimited list of paths to Disk and name the
variable as mount_paths/mount_path_list instead of mount_path?

http://codereview.chromium.org/6838011/diff/1011/udev-device.cc
File udev-device.cc (right):

http://codereview.chromium.org/6838011/diff/1011/udev-device.cc#newcode153
udev-device.cc:153: }
My bad.  If Disk accepts a delimited list of mounted paths, we need to change
the code here to construct the list, or perhaps add
UdevDevice::GetMountedPathsString?

[rtc, 2011-04-13 16:36:54]

On Wed, Apr 13, 2011 at 8:11 AM, <benchan@chromium.org> wrote:

>
> http://codereview.chromium.org/6838011/diff/1011/cros-disks.conf
> File cros-disks.conf (right):
>
> http://codereview.chromium.org/6838011/diff/1011/cros-disks.conf#newcode7
> cros-disks.conf:7: env CROS_DISKS_LOG_FILE=/var/log/crosdisks.log
> How about naming it as cros-disks.log for consistency?
>
> http://codereview.chromium.org/6838011/diff/1011/cros-disks.conf#newcode20
> cros-disks.conf:20: chmod 0755 "${CROS_DISKS_LOG_FILE}"
> Should the log file permission be 0644?
>
> And should the log directory permission be set?
>
> http://codereview.chromium.org/6838011/diff/1011/disk.cc
> File disk.cc (right):
>
> http://codereview.chromium.org/6838011/diff/1011/disk.cc#newcode41
> disk.cc:41:
> disk[kDeviceMountPaths].writer().append_string(mount_path().c_str());
> According to
>
>
http://hal.freedesktop.org/docs/DeviceKit-disks/Device.html#Device:device-mou...
> ,
> DeviceMountPaths is a list of paths in the root namespace where the root
> of the device is mounted. Should we pass a delimited list of paths to
> Disk and name the variable as mount_paths/mount_path_list instead of
> mount_path?
>
> http://codereview.chromium.org/6838011/diff/1011/udev-device.cc
> File udev-device.cc (right):
>
> http://codereview.chromium.org/6838011/diff/1011/udev-device.cc#newcode153
> udev-device.cc:153: }
> My bad.  If Disk accepts a delimited list of mounted paths, we need to
> change the code here to construct the list, or perhaps add
> UdevDevice::GetMountedPathsString?


The client accepts a single mount path. Let's leave it as is for now until
things work end-to-end

>
>
> http://codereview.chromium.org/6838011/
>

[Ben Chan, 2011-04-13 16:46:55]

LGTM

On 2011/04/13 16:36:54, rtc wrote:
> On Wed, Apr 13, 2011 at 8:11 AM, <mailto:benchan@chromium.org> wrote:
> 
> >
> > http://codereview.chromium.org/6838011/diff/1011/cros-disks.conf
> > File cros-disks.conf (right):
> >
> > http://codereview.chromium.org/6838011/diff/1011/cros-disks.conf#newcode7
> > cros-disks.conf:7: env CROS_DISKS_LOG_FILE=/var/log/crosdisks.log
> > How about naming it as cros-disks.log for consistency?
> >
> > http://codereview.chromium.org/6838011/diff/1011/cros-disks.conf#newcode20
> > cros-disks.conf:20: chmod 0755 "${CROS_DISKS_LOG_FILE}"
> > Should the log file permission be 0644?
> >
> > And should the log directory permission be set?
> >
> > http://codereview.chromium.org/6838011/diff/1011/disk.cc
> > File disk.cc (right):
> >
> > http://codereview.chromium.org/6838011/diff/1011/disk.cc#newcode41
> > disk.cc:41:
> > disk[kDeviceMountPaths].writer().append_string(mount_path().c_str());
> > According to
> >
> >
>
http://hal.freedesktop.org/docs/DeviceKit-disks/Device.html#Device:device-mou...
> > ,
> > DeviceMountPaths is a list of paths in the root namespace where the root
> > of the device is mounted. Should we pass a delimited list of paths to
> > Disk and name the variable as mount_paths/mount_path_list instead of
> > mount_path?
> >
> > http://codereview.chromium.org/6838011/diff/1011/udev-device.cc
> > File udev-device.cc (right):
> >
> > http://codereview.chromium.org/6838011/diff/1011/udev-device.cc#newcode153
> > udev-device.cc:153: }
> > My bad.  If Disk accepts a delimited list of mounted paths, we need to
> > change the code here to construct the list, or perhaps add
> > UdevDevice::GetMountedPathsString?
> 
> 
> The client accepts a single mount path. Let's leave it as is for now until
> things work end-to-end
> 
> >
> >
> > http://codereview.chromium.org/6838011/
> >

[rtc, 2011-04-13 17:59:43]

On Wed, Apr 13, 2011 at 8:11 AM, <benchan@chromium.org> wrote:

>
> http://codereview.chromium.org/6838011/diff/1011/cros-disks.conf
> File cros-disks.conf (right):
>
> http://codereview.chromium.org/6838011/diff/1011/cros-disks.conf#newcode7
> cros-disks.conf:7: env CROS_DISKS_LOG_FILE=/var/log/crosdisks.log
> How about naming it as cros-disks.log for consistency?
>
> http://codereview.chromium.org/6838011/diff/1011/cros-disks.conf#newcode20
> cros-disks.conf:20: chmod 0755 "${CROS_DISKS_LOG_FILE}"
> Should the log file permission be 0644?
>
> And should the log directory permission be set?
>

The new logging does away with the need to create the file in the first
place, so I removed it from the code. I also updated the rules in the
upstart conf file to play nicely with the boot work that Richard is trying
to do.

PTAL


>
> http://codereview.chromium.org/6838011/diff/1011/disk.cc
> File disk.cc (right):
>
> http://codereview.chromium.org/6838011/diff/1011/disk.cc#newcode41
> disk.cc:41:
> disk[kDeviceMountPaths].writer().append_string(mount_path().c_str());
> According to
>
>
http://hal.freedesktop.org/docs/DeviceKit-disks/Device.html#Device:device-mou...
> ,
> DeviceMountPaths is a list of paths in the root namespace where the root
> of the device is mounted. Should we pass a delimited list of paths to
> Disk and name the variable as mount_paths/mount_path_list instead of
> mount_path?
>
> http://codereview.chromium.org/6838011/diff/1011/udev-device.cc
> File udev-device.cc (right):
>
> http://codereview.chromium.org/6838011/diff/1011/udev-device.cc#newcode153
> udev-device.cc:153: }
> My bad.  If Disk accepts a delimited list of mounted paths, we need to
> change the code here to construct the list, or perhaps add
> UdevDevice::GetMountedPathsString?
>
>
> http://codereview.chromium.org/6838011/
>

[Ben Chan, 2011-04-13 18:03:04]

LGTM

On 2011/04/13 17:59:43, rtc wrote:
> On Wed, Apr 13, 2011 at 8:11 AM, <mailto:benchan@chromium.org> wrote:
> 
> >
> > http://codereview.chromium.org/6838011/diff/1011/cros-disks.conf
> > File cros-disks.conf (right):
> >
> > http://codereview.chromium.org/6838011/diff/1011/cros-disks.conf#newcode7
> > cros-disks.conf:7: env CROS_DISKS_LOG_FILE=/var/log/crosdisks.log
> > How about naming it as cros-disks.log for consistency?
> >
> > http://codereview.chromium.org/6838011/diff/1011/cros-disks.conf#newcode20
> > cros-disks.conf:20: chmod 0755 "${CROS_DISKS_LOG_FILE}"
> > Should the log file permission be 0644?
> >
> > And should the log directory permission be set?
> >
> 
> The new logging does away with the need to create the file in the first
> place, so I removed it from the code. I also updated the rules in the
> upstart conf file to play nicely with the boot work that Richard is trying
> to do.
> 
> PTAL
> 
> 
> >
> > http://codereview.chromium.org/6838011/diff/1011/disk.cc
> > File disk.cc (right):
> >
> > http://codereview.chromium.org/6838011/diff/1011/disk.cc#newcode41
> > disk.cc:41:
> > disk[kDeviceMountPaths].writer().append_string(mount_path().c_str());
> > According to
> >
> >
>
http://hal.freedesktop.org/docs/DeviceKit-disks/Device.html#Device:device-mou...
> > ,
> > DeviceMountPaths is a list of paths in the root namespace where the root
> > of the device is mounted. Should we pass a delimited list of paths to
> > Disk and name the variable as mount_paths/mount_path_list instead of
> > mount_path?
> >
> > http://codereview.chromium.org/6838011/diff/1011/udev-device.cc
> > File udev-device.cc (right):
> >
> > http://codereview.chromium.org/6838011/diff/1011/udev-device.cc#newcode153
> > udev-device.cc:153: }
> > My bad.  If Disk accepts a delimited list of mounted paths, we need to
> > change the code here to construct the list, or perhaps add
> > UdevDevice::GetMountedPathsString?
> >
> >
> > http://codereview.chromium.org/6838011/
> >