Issue 683793003: [turbofan] fold constants in compares

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 683793003: [turbofan] fold constants in compares (Closed)

Created:
6 years, 1 month ago by dcarney

Modified:
6 years, 1 month ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

[turbofan] fold constants in compares R=bmeurer@chromium.org BUG=

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+242 lines, -104 lines)			Patch
M	src/compiler/machine-operator-reducer.h	View	1 2 3 4	1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/compiler/machine-operator-reducer.cc	View	1 2 3 4 5	3 chunks	+191 lines, -104 lines	0 comments	Download
M	test/unittests/compiler/machine-operator-reducer-unittest.cc	View	1 2 3 4 5	2 chunks	+43 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Benedikt Meurer

6 years, 1 month ago (2014-10-30 07:54:27 UTC) #4

Actually NOT LGTM, because it breaks the Unity3D WebGL Benchmark.