Adds ozone support for ime keyboard.

Adds ozone support for ime keyboard.

BUG=342336
Committed: https://crrev.com/8be55caf3d38bba7645de143f7e6b8b655fdd36c
Cr-Commit-Position: refs/heads/master@{#302057}

[FengYuan, 2014-10-28 05:24:13]

fengyuan@chromium.org changed reviewers:
+ shuchen@chromium.org

[FengYuan, 2014-10-28 07:05:09]

PTAL

[Shu Chen, 2014-10-28 07:10:44]

https://codereview.chromium.org/683773002/diff/1/chromeos/ime/ime_keyboard.h
File chromeos/ime/ime_keyboard.h (right):

https://codereview.chromium.org/683773002/diff/1/chromeos/ime/ime_keyboard.h#...
chromeos/ime/ime_keyboard.h:80: };
Please move the white lists into ime_keyboard.cc file.

https://codereview.chromium.org/683773002/diff/1/chromeos/ime/ime_keyboard.h#...
chromeos/ime/ime_keyboard.h:95: virtual void AddObserver(Observer* observer) =
0;
remove "= 0". Same for the rests.

[FengYuan, 2014-10-28 08:02:47]

PTAL

https://codereview.chromium.org/683773002/diff/1/chromeos/ime/ime_keyboard.h
File chromeos/ime/ime_keyboard.h (right):

https://codereview.chromium.org/683773002/diff/1/chromeos/ime/ime_keyboard.h#...
chromeos/ime/ime_keyboard.h:80: };
On 2014/10/28 07:10:44, Shu Chen wrote:
> Please move the white lists into ime_keyboard.cc file.

Done.

https://codereview.chromium.org/683773002/diff/1/chromeos/ime/ime_keyboard.h#...
chromeos/ime/ime_keyboard.h:95: virtual void AddObserver(Observer* observer) =
0;
On 2014/10/28 07:10:44, Shu Chen wrote:
> remove "= 0". Same for the rests.

Done.

[Shu Chen, 2014-10-28 08:53:07]

lgtm

https://codereview.chromium.org/683773002/diff/20001/chromeos/ime/fake_ime_ke...
File chromeos/ime/fake_ime_keyboard.cc (right):

https://codereview.chromium.org/683773002/diff/20001/chromeos/ime/fake_ime_ke...
chromeos/ime/fake_ime_keyboard.cc:35: bool
ImeKeyboard::ReapplyCurrentKeyboardLayout() {
s/ImeKeyboard/FakeImeKeyboard/g

Please make sure the patch set can pass compile on your local before uploading
to cl. Thanks

[FengYuan, 2014-10-30 08:35:05]

The CQ bit was checked by fengyuan@chromium.org

[commit-bot: I haz the power, 2014-10-30 08:35:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/683773002/120001

[commit-bot: I haz the power, 2014-10-30 09:19:27]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2014-10-30 09:20:08]

Patchset 7 (id:??) landed as
https://crrev.com/8be55caf3d38bba7645de143f7e6b8b655fdd36c
Cr-Commit-Position: refs/heads/master@{#302057}

[yurys, 2014-10-30 10:12:12]

A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/689873004/ by yurys@chromium.org.

The reason for reverting is: Change doesn't compile on Linux ChromiumOS Ozone
Builder

http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20C....