Fix bug where AppInfoDialog was outliving ExtensionSettingsHandler

Fix bug where AppInfoDialog was outliving ExtensionSettingsHandler

Fixed bug on Ubuntu Linux where the AppInfoDialog was outliving the
ExtensionSettingsHandler, causing Chrome to crash when the browser
window was closed while the dialog was open. This used to only happen
on Mac (where the dialog is disabled), but now happens on Linux Unity
due to Unity's always-accessible close/minimise/maximise toolbar.

TEST=Make Chrome fullscreen on Ubuntu with Unity enabled, then navigate
to chrome://extensions, click Details next to an app, and close Chrome
by clicking the X in Unity's fullscreen toolbar (not in Chrome). Chrome
should close gracefully and not crash.
BUG=427506
Committed: https://crrev.com/fc3df0bae9f7d607a6bd3e7472ebe0b6a9d92074
Cr-Commit-Position: refs/heads/master@{#302566}

[sashab, 2014-11-03 05:49:45]

sashab@chromium.org changed reviewers:
+ kalman@chromium.org

[sashab, 2014-11-03 05:49:46]

Small patch; just uses BrokerDelegate to pass an ExtensionSettingsHandler* like
the previous permissions dialog did.

[not at google - send to devlin, 2014-11-03 17:37:49]

lgtm

https://codereview.chromium.org/683763003/diff/1/chrome/browser/ui/webui/exte...
File chrome/browser/ui/webui/extensions/extension_settings_handler.cc (right):

https://codereview.chromium.org/683763003/diff/1/chrome/browser/ui/webui/exte...
chrome/browser/ui/webui/extensions/extension_settings_handler.cc:142: // On Mac
(and Linux with Unity), the install prompt is not modal. This means
How about just "The install prompt is not necessarily modal (e.g. Mac, Linux
Unity)".

Cover your bases for the future.

[sashab, 2014-11-04 01:32:21]

https://codereview.chromium.org/683763003/diff/1/chrome/browser/ui/webui/exte...
File chrome/browser/ui/webui/extensions/extension_settings_handler.cc (right):

https://codereview.chromium.org/683763003/diff/1/chrome/browser/ui/webui/exte...
chrome/browser/ui/webui/extensions/extension_settings_handler.cc:142: // On Mac
(and Linux with Unity), the install prompt is not modal. This means
On 2014/11/03 17:37:49, kalman wrote:
> How about just "The install prompt is not necessarily modal (e.g. Mac, Linux
> Unity)".
> 
> Cover your bases for the future.

Nice suggestion; done.

[sashab, 2014-11-04 01:32:25]

The CQ bit was checked by sashab@chromium.org

[commit-bot: I haz the power, 2014-11-04 01:34:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/683763003/20001

[commit-bot: I haz the power, 2014-11-04 03:14:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-11-04 03:14:51]

Patchset 2 (id:??) landed as
https://crrev.com/fc3df0bae9f7d607a6bd3e7472ebe0b6a9d92074
Cr-Commit-Position: refs/heads/master@{#302566}