Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 683753005: C++11: Use template aliases instead of inheritance (Closed)

Created:
6 years, 1 month ago by Mark Mentovai
Modified:
6 years, 1 month ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

C++11: Use template aliases instead of inheritance. This only came up in one location, PointerVector. A template alias is superior to inheritance, which doesn’t provide full type equivalence and doesn’t automatically inherit non-default constructors. R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/bbeef320e03b9f43893e19a37e4ac1461bc7cd8d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M util/stdlib/pointer_container.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
6 years, 1 month ago (2014-11-05 19:31:18 UTC) #2
Robert Sesek
LGTM
6 years, 1 month ago (2014-11-05 19:51:43 UTC) #3
Mark Mentovai
6 years, 1 month ago (2014-11-05 19:54:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bbeef320e03b9f43893e19a37e4ac1461bc7cd8d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698