Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 683753004: [turbofan] Transform x * -1.0 to -0.0 - x. (Closed)

Created:
6 years, 1 month ago by Benedikt Meurer
Modified:
6 years, 1 month ago
Reviewers:
Jarin
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Transform x * -1.0 to -0.0 - x. TEST=msjunit/asm,unittests R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25176

Patch Set 1 #

Total comments: 2

Patch Set 2 : Corner cases. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -0 lines) Patch
M src/compiler/machine-operator-reducer.cc View 1 chunk +6 lines, -0 lines 0 comments Download
A test/mjsunit/asm/float64mul.js View 1 1 chunk +33 lines, -0 lines 0 comments Download
M test/unittests/compiler/machine-operator-reducer-unittest.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 1 chunk +2 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Benedikt Meurer
PTAL
6 years, 1 month ago (2014-11-06 05:23:12 UTC) #2
Jarin
lgtm. https://codereview.chromium.org/683753004/diff/1/test/mjsunit/asm/float64mul.js File test/mjsunit/asm/float64mul.js (right): https://codereview.chromium.org/683753004/diff/1/test/mjsunit/asm/float64mul.js#newcode23 test/mjsunit/asm/float64mul.js:23: } Could we possibly test the corner cases, ...
6 years, 1 month ago (2014-11-06 06:07:49 UTC) #3
Benedikt Meurer
https://codereview.chromium.org/683753004/diff/1/test/mjsunit/asm/float64mul.js File test/mjsunit/asm/float64mul.js (right): https://codereview.chromium.org/683753004/diff/1/test/mjsunit/asm/float64mul.js#newcode23 test/mjsunit/asm/float64mul.js:23: } On 2014/11/06 06:07:49, jarin wrote: > Could we ...
6 years, 1 month ago (2014-11-06 06:12:47 UTC) #4
Benedikt Meurer
6 years, 1 month ago (2014-11-06 06:13:21 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 25176 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698