Issue 683753003: Revert of Bisect Mac performance regression.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 683753003: Revert of Bisect Mac performance regression. (Closed)

Created:
6 years, 1 month ago by egdaniel

Modified:
6 years, 1 month ago

Reviewers:
bungeman-skia, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Revert of Bisect Mac performance regression. (patchset #6 id:100001 of https://codereview.chromium.org/693213002/) Reason for revert: Block deps roll by breaking webkit test hit-test-counts on mac. Original issue's description: > With https://chromium.googlesource.com/skia/+/43b8b36b20ae00e2d78421c4cda1f3f922983a20 blink_perf.layout regressed. It appears that the typeface cache is being missed. This is a partial revert of the Skia change which reverts the smallest amount of code to restore performance. > > BUG=chromium:425566 > > Committed: https://skia.googlesource.com/skia/+/47eda52e8fb88f0725b401762a3e0bddc98e9fb3 TBR=reed@google.com,bungeman@google.com NOTREECHECKS=true NOTRY=true BUG=chromium:425566 Committed: https://skia.googlesource.com/skia/+/a3d3065eeae5bb177895d3bd840c3d07706f5400

Created: 6 years, 1 month ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -24 lines)			Patch
	M	src/ports/SkFontHost_mac.cpp	View		7 chunks	+25 lines, -24 lines	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/683753003/1

6 years, 1 month ago (2014-11-05 15:39:57 UTC) #2

commit-bot: I haz the power

6 years, 1 month ago (2014-11-05 15:40:12 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as a3d3065eeae5bb177895d3bd840c3d07706f5400