Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 683753002: Add a missing dependency from gcm_driver. (Closed)

Created:
6 years, 1 month ago by Jun Mukai
Modified:
6 years, 1 month ago
Reviewers:
Dmitry Titov
CC:
chromium-reviews, zea+watch_chromium.org, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add a missing dependency from gcm_driver. BUG=None TBR=dimich@chromium.org TEST=manually Committed: https://crrev.com/fc3f784458badb17ac6ddc060c4d48ff808ed1b3 Cr-Commit-Position: refs/heads/master@{#301569}

Patch Set 1 #

Patch Set 2 : fix android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M components/gcm_driver/BUILD.gn View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Jun Mukai
6 years, 1 month ago (2014-10-28 04:42:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/683753002/1
6 years, 1 month ago (2014-10-28 04:44:16 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/11923) android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/28664)
6 years, 1 month ago (2014-10-28 04:52:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/683753002/20001
6 years, 1 month ago (2014-10-28 04:58:10 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-28 05:47:44 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 05:48:28 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fc3f784458badb17ac6ddc060c4d48ff808ed1b3
Cr-Commit-Position: refs/heads/master@{#301569}

Powered by Google App Engine
This is Rietveld 408576698