Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 683733013: Add support for the apks (non os.X_OK) to compare_build_artifacts.py (Closed)

Created:
6 years, 1 month ago by Sébastien Marchand
Modified:
6 years, 1 month ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, pgervais+watch_chromium.org, kjellander-cc_chromium.org, cmp-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Project:
tools
Visibility:
Public.

Description

Add support for the apks (non os.X_OK) to compare_build_artifacts.py BUG=314403 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=292855

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Sébastien Marchand
PTAL.
6 years, 1 month ago (2014-11-05 19:38:00 UTC) #2
M-A Ruel
lgtm
6 years, 1 month ago (2014-11-05 19:52:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/683733013/1
6 years, 1 month ago (2014-11-05 19:52:40 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 19:53:22 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 292855

Powered by Google App Engine
This is Rietveld 408576698