Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Side by Side Diff: PRESUBMIT.py

Issue 683733009: Clean up PRESUBMIT.py - remove references to removed clang trybots (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | PRESUBMIT_test.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl. 8 for more details about the presubmit API built into gcl.
9 """ 9 """
10 10
(...skipping 1696 matching lines...) Expand 10 before | Expand all | Expand 10 after
1707 'android_arm64_dbg_recipe', 1707 'android_arm64_dbg_recipe',
1708 'android_chromium_gn_compile_rel', 1708 'android_chromium_gn_compile_rel',
1709 'android_chromium_gn_compile_dbg', 1709 'android_chromium_gn_compile_dbg',
1710 'android_clang_dbg', 1710 'android_clang_dbg',
1711 'android_clang_dbg_recipe', 1711 'android_clang_dbg_recipe',
1712 'android_dbg_tests_recipe', 1712 'android_dbg_tests_recipe',
1713 'ios_dbg_simulator', 1713 'ios_dbg_simulator',
1714 'ios_rel_device', 1714 'ios_rel_device',
1715 'ios_rel_device_ninja', 1715 'ios_rel_device_ninja',
1716 'linux_chromium_chromeos_rel', 1716 'linux_chromium_chromeos_rel',
1717 'linux_chromium_clang_dbg',
1718 'linux_chromium_gn_dbg', 1717 'linux_chromium_gn_dbg',
1719 'linux_chromium_gn_rel', 1718 'linux_chromium_gn_rel',
1720 'linux_chromium_rel_ng', 1719 'linux_chromium_rel_ng',
1721 'linux_gpu', 1720 'linux_gpu',
1722 'mac_chromium_compile_dbg', 1721 'mac_chromium_compile_dbg',
1723 'mac_chromium_rel_ng', 1722 'mac_chromium_rel_ng',
1724 'mac_gpu', 1723 'mac_gpu',
1725 'win_chromium_compile_dbg', 1724 'win_chromium_compile_dbg',
1726 'win_chromium_rel_ng', 1725 'win_chromium_rel_ng',
1727 'win_chromium_x64_rel_ng', 1726 'win_chromium_x64_rel_ng',
1728 'win_gpu', 1727 'win_gpu',
1729 'win8_chromium_rel', 1728 'win8_chromium_rel',
1730 ] 1729 ]
1731 1730
1732 # Match things like path/aura/file.cc and path/file_aura.cc. 1731 # Match things like path/aura/file.cc and path/file_aura.cc.
1733 # Same for chromeos. 1732 # Same for chromeos.
1734 if any(re.search(r'[\\\/_](aura|chromeos)', f) for f in files): 1733 if any(re.search(r'[\\\/_](aura|chromeos)', f) for f in files):
1735 builders.extend([ 1734 builders.extend([
1736 'linux_chromeos_asan', 1735 'linux_chromeos_asan',
1737 'linux_chromium_chromeos_clang_dbg'
1738 ]) 1736 ])
1739 1737
1740 # If there are gyp changes to base, build, or chromeos, run a full cros build 1738 # If there are gyp changes to base, build, or chromeos, run a full cros build
1741 # in addition to the shorter linux_chromeos build. Changes to high level gyp 1739 # in addition to the shorter linux_chromeos build. Changes to high level gyp
1742 # files have a much higher chance of breaking the cros build, which is 1740 # files have a much higher chance of breaking the cros build, which is
1743 # differnt from the linux_chromeos build that most chrome developers test 1741 # differnt from the linux_chromeos build that most chrome developers test
1744 # with. 1742 # with.
1745 if any(re.search('^(base|build|chromeos).*\.gypi?$', f) for f in files): 1743 if any(re.search('^(base|build|chromeos).*\.gypi?$', f) for f in files):
1746 builders.extend(['cros_x86']) 1744 builders.extend(['cros_x86'])
1747 1745
1748 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it 1746 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it
1749 # unless they're .gyp(i) files as changes to those files can break the gyp 1747 # unless they're .gyp(i) files as changes to those files can break the gyp
1750 # step on that bot. 1748 # step on that bot.
1751 if (not all(re.search('^chrome', f) for f in files) or 1749 if (not all(re.search('^chrome', f) for f in files) or
1752 any(re.search('\.gypi?$', f) for f in files)): 1750 any(re.search('\.gypi?$', f) for f in files)):
1753 builders.extend(['android_aosp']) 1751 builders.extend(['android_aosp'])
1754 1752
1755 return GetDefaultTryConfigs(builders) 1753 return GetDefaultTryConfigs(builders)
OLDNEW
« no previous file with comments | « no previous file | PRESUBMIT_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698