Start accepting http connections in next run loop.

Start accepting http connections in next run loop.

Devtools is not ready to get callbacks if accept returns connections
synchronously.

BUG=428389
Committed: https://crrev.com/baa7546a8bef46c86c875084dd11517a3c19bf3d
Cr-Commit-Position: refs/heads/master@{#302309}

[byungchul, 2014-10-31 17:33:04]

byungchul@chromium.org changed reviewers:
+ mmenke@chromium.org

[mmenke, 2014-10-31 17:57:41]

Could you update http_server.h to mention this behavior (Which I think is pretty
reasonable - re-entrancy issues are common enough, that it makes sense to work
around it here, rather than in devtools).

[byungchul, 2014-10-31 18:21:12]

On 2014/10/31 17:57:41, mmenke wrote:
> Could you update http_server.h to mention this behavior (Which I think is
pretty
> reasonable - re-entrancy issues are common enough, that it makes sense to work
> around it here, rather than in devtools).

done

[mmenke, 2014-10-31 18:23:02]

LGTM

https://codereview.chromium.org/683733006/diff/20001/net/server/http_server.h
File net/server/http_server.h (right):

https://codereview.chromium.org/683733006/diff/20001/net/server/http_server.h...
net/server/http_server.h:45: // connections in next run loop in case when
|delegate| is not ready to get
nit:  Maybe just "next run loop" -> "asynchronously"  (RunLoop is a class
intended for testing, so the phrase "run loop" can be a bit ambiguous, and it's
not necessary the next task run - may be others in the queue).

[byungchul, 2014-10-31 18:42:56]

https://codereview.chromium.org/683733006/diff/20001/net/server/http_server.h
File net/server/http_server.h (right):

https://codereview.chromium.org/683733006/diff/20001/net/server/http_server.h...
net/server/http_server.h:45: // connections in next run loop in case when
|delegate| is not ready to get
On 2014/10/31 18:23:02, mmenke wrote:
> nit:  Maybe just "next run loop" -> "asynchronously"  (RunLoop is a class
> intended for testing, so the phrase "run loop" can be a bit ambiguous, and
it's
> not necessary the next task run - may be others in the queue).

Done.

[byungchul, 2014-10-31 18:43:20]

The CQ bit was checked by byungchul@chromium.org

[commit-bot: I haz the power, 2014-10-31 18:45:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/683733006/40001

[commit-bot: I haz the power, 2014-10-31 19:38:16]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-10-31 19:39:53]

Patchset 3 (id:??) landed as
https://crrev.com/baa7546a8bef46c86c875084dd11517a3c19bf3d
Cr-Commit-Position: refs/heads/master@{#302309}