Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Unified Diff: Source/bindings/core/v8/ScriptPromisePropertyBase.cpp

Issue 683733003: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/ScriptPromisePropertyBase.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/ScriptPromisePropertyBase.cpp
diff --git a/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp b/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp
index cadb7146f27fb37f5a6ae94e44464f03d9ca5766..f0c5ac07de174cb6508231b71453e56646dac8ef 100644
--- a/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp
+++ b/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp
@@ -112,10 +112,10 @@ void ScriptPromisePropertyBase::resolveOrRejectInternal(v8::Handle<v8::Promise::
ASSERT_NOT_REACHED();
break;
case Resolved:
- resolver->Resolve(resolvedValue(resolver->CreationContext()->Global(), m_isolate));
+ resolver->Resolve(resolvedValue(m_isolate, resolver->CreationContext()->Global()));
break;
case Rejected:
- resolver->Reject(rejectedValue(resolver->CreationContext()->Global(), m_isolate));
+ resolver->Reject(rejectedValue(m_isolate, resolver->CreationContext()->Global()));
break;
}
}
« no previous file with comments | « Source/bindings/core/v8/ScriptPromisePropertyBase.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698