Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 683733002: ServiceWorker: Remove the obsolete "parsed" state [3/3] (Closed)

Created:
6 years, 1 month ago by nhiroki
Modified:
6 years, 1 month ago
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, falken, dglazkov+blink, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

ServiceWorker: Remove the obsolete "parsed" state [3/3] Spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#service-worker-state [1] Blink: https://codereview.chromium.org/678253002/ [2] Chromium: https://codereview.chromium.org/685503004/ [3] Blink: THIS PATCH BUG=424081 TEST=run-webkit-tests --debug http/tests/serviceworker/ Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184520

Patch Set 1 #

Patch Set 2 : remove unnecessary test expectations #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -17 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/registration-end-to-end.html View 1 2 2 chunks +1 line, -4 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/state.html View 1 2 2 chunks +2 lines, -6 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorker.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M public/platform/WebServiceWorkerState.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
dominicc (has gone to gerrit)
lgtm
6 years, 1 month ago (2014-10-28 02:04:31 UTC) #2
nhiroki
tkent@: Can you give me your stamp for public/platform/WebServiceWorkerState.h? Thanks.
6 years, 1 month ago (2014-10-28 02:21:06 UTC) #3
nhiroki
+tkent@: Can you give me your stamp for public/platform/WebServiceWorkerState.h? Thanks.
6 years, 1 month ago (2014-10-28 02:21:51 UTC) #5
tkent
lgtm
6 years, 1 month ago (2014-10-28 02:27:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/683733002/20001
6 years, 1 month ago (2014-10-28 02:28:01 UTC) #8
commit-bot: I haz the power
Failed to apply patch for LayoutTests/TestExpectations: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 1 month ago (2014-10-28 02:28:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/683733002/20001
6 years, 1 month ago (2014-10-28 12:11:37 UTC) #12
commit-bot: I haz the power
Failed to apply patch for LayoutTests/TestExpectations: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 1 month ago (2014-10-28 12:11:46 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/683733002/40001
6 years, 1 month ago (2014-10-28 12:22:39 UTC) #16
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 13:48:34 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 184520

Powered by Google App Engine
This is Rietveld 408576698