LayoutTests/svg/clip-path/clip-path-w-broken-filter-on-shape.html - Issue 683703005: Prefer unprefixed clip-path to (webkit) prefixed

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/svg/clip-path/clip-path-w-broken-filter-on-shape.html

Issue 683703005: Prefer unprefixed clip-path to (webkit) prefixed (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <svg>

	3 <clipPath id="c">

	4 <text></text>
	f(malita) 2014/10/31 17:24:46 Just curious: I assume this is to force the mask p Just curious: I assume this is to force the mask path in RenderSVGResourceClipper, but why is that needed? fs 2014/10/31 19:29:22 It's needed because the path/path-ops codepath (ri Show quoted text On 2014/10/31 17:24:46, Florin Malita wrote: > Just curious: I assume this is to force the mask path in > RenderSVGResourceClipper, but why is that needed? It's needed because the path/path-ops codepath (rightfully) ignores filters (and other resources) altogether. It seemed less like that that (<text>) restriction would be lifted than, say, the clip-on-clip or clipped-clip-shape ones. f(malita) 2014/10/31 19:36:35 Ack. Show quoted text On 2014/10/31 19:29:22, fs wrote: > On 2014/10/31 17:24:46, Florin Malita wrote: > > Just curious: I assume this is to force the mask path in > > RenderSVGResourceClipper, but why is that needed? > > It's needed because the path/path-ops codepath (rightfully) ignores filters (and > other resources) altogether. It seemed less like that that (<text>) restriction > would be lifted than, say, the clip-on-clip or clipped-clip-shape ones. Ack.
	5 <rect width="100" height="100" filter="url(#nonexistent)"/>

	6 </clipPath>

	7 <rect width="200" height="100" fill="green" clip-path="url(#c)"/>

	8 </svg>

OLD	NEW