Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 683703003: Remove various Heap* types. (Closed)

Created:
6 years, 1 month ago by eseidel
Modified:
6 years, 1 month ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove various Heap* types. Also removed a bunch of trace() methods which I touched by accident. Turns out they're all very interconnected sadly. I re-wrote Supplement to not use templates in an earlier version of this patch but hit some trouble with vtables and decided to table that work for a later time once more of oilpan has been unwound. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/9564233315df4264901882bbf4e86b6417f9c68b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -989 lines) Patch
M sky/engine/core/css/CSSCanvasValue.h View 2 chunks +0 lines, -7 lines 0 comments Download
M sky/engine/core/css/CSSCanvasValue.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M sky/engine/core/dom/Document.h View 2 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/core/dom/Document.cpp View 2 chunks +0 lines, -47 lines 0 comments Download
M sky/engine/core/dom/ExecutionContext.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/dom/ExecutionContext.cpp View 2 chunks +0 lines, -13 lines 0 comments Download
M sky/engine/core/fetch/MemoryCache.h View 1 chunk +0 lines, -9 lines 0 comments Download
M sky/engine/core/fetch/MemoryCache.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M sky/engine/core/frame/LocalDOMWindow.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/frame/LocalDOMWindow.cpp View 1 chunk +0 lines, -15 lines 0 comments Download
M sky/engine/core/frame/Screen.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/frame/Screen.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/core/html/HTMLCanvasElement.h View 2 chunks +0 lines, -4 lines 0 comments Download
M sky/engine/core/html/HTMLCanvasElement.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M sky/engine/core/html/HTMLMediaElement.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/html/HTMLMediaElement.cpp View 1 chunk +0 lines, -12 lines 0 comments Download
M sky/engine/core/html/HTMLVideoElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/HTMLVideoElement.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M sky/engine/core/html/imports/HTMLImportsController.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/html/imports/HTMLImportsController.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M sky/engine/core/inspector/InspectorNodeIds.cpp View 2 chunks +0 lines, -35 lines 0 comments Download
M sky/engine/core/page/Page.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/page/Page.cpp View 1 chunk +0 lines, -12 lines 0 comments Download
M sky/engine/platform/LifecycleContext.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/platform/RefCountedSupplement.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/platform/Supplementable.h View 4 chunks +0 lines, -39 lines 0 comments Download
M sky/engine/platform/heap/Handle.h View 2 chunks +0 lines, -32 lines 0 comments Download
M sky/engine/platform/heap/Heap.h View 4 chunks +0 lines, -698 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
eseidel
6 years, 1 month ago (2014-10-28 01:18:45 UTC) #1
abarth-chromium
lgtm
6 years, 1 month ago (2014-10-28 01:19:16 UTC) #2
eseidel
6 years, 1 month ago (2014-10-28 01:19:51 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9564233315df4264901882bbf4e86b6417f9c68b.

Powered by Google App Engine
This is Rietveld 408576698