chrome/test/data/extensions/platform_apps/custom_launcher_page/main.js - Issue 683703002: Notify launcher page with onTransitionChanged event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/platform_apps/custom_launcher_page/main.js

Issue 683703002: Notify launcher page with onTransitionChanged event (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@launcher_page_api_show_state_notify

Patch Set: nullptr like it's 1999 Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/api/launcher_page_private.idl ('K') | « chrome/common/extensions/api/schemas.gypi ('k') | ui/app_list/app_list_model.h » ('j') | ui/app_list/app_list_model.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/platform_apps/custom_launcher_page/main.js

diff --git a/chrome/test/data/extensions/platform_apps/custom_launcher_page/main.js b/chrome/test/data/extensions/platform_apps/custom_launcher_page/main.js

index 9837e850c2a11df1a3c2d5ce2e78877091d8133e..18b047ae2dd1b39da7394459a38cc0fff0c015f8 100644

--- a/chrome/test/data/extensions/platform_apps/custom_launcher_page/main.js

+++ b/chrome/test/data/extensions/platform_apps/custom_launcher_page/main.js

@@ -2,4 +2,11 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

+chrome.launcherPagePrivate.onTransitionChanged.addListener(function(progress) {

Matt Giuca 2014/11/03 00:57:42 Same here... doesn't seem updated to the new API.

calamity 2014/11/06 02:36:32 It has. onTransitionChanged is the new API. The co

+ if (progress == 0)

+ chrome.test.sendMessage('onPageCollapsed');

+ else if (progress == 1)

+ chrome.test.sendMessage('onPageExpanded');

+})

chrome.test.sendMessage('Launched');

« chrome/common/extensions/api/launcher_page_private.idl ('K') | « chrome/common/extensions/api/schemas.gypi ('k') | ui/app_list/app_list_model.h » ('j') | ui/app_list/app_list_model.h » ('J')