chrome/test/data/extensions/platform_apps/custom_launcher_page/main.js - Issue 683703002: Notify launcher page with onTransitionChanged event - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(27)

My Issues | Starred Open | Closed | All

Side by Side Diff: chrome/test/data/extensions/platform_apps/custom_launcher_page/main.js

Issue 683703002: Notify launcher page with onTransitionChanged event (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@launcher_page_api_show_state_notify

Patch Set: address tapted@'s comments Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/apps/custom_launcher_page_browsertest_views.cc ('K') | « chrome/common/extensions/api/schemas.gypi ('k') | ui/app_list/app_list_model.h » ('j') | ui/app_list/views/contents_view.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

	5 chrome.launcherPage.onTransitionChanged.addListener(function(progress) {

	6 if (progress == 0)

	7 chrome.test.sendMessage('onPageCollapsed');
	Matt Giuca 2014/11/07 06:46:29 Ah I think I understand now... onPageCollapsed and Ah I think I understand now... onPageCollapsed and onPageExpanded are not part of the API; they are test messages. Can you rename them to progressAt0Percent and progressAt100Percent or something? That would make it seem less like an actual API message (especially if we later decide to add onPageCollapsed and onPageExpanded messages to the API; then it could get really confusing). calamity 2014/11/10 03:38:30 Done. Show quoted text On 2014/11/07 06:46:29, Matt Giuca wrote: > Ah I think I understand now... onPageCollapsed and onPageExpanded are not part > of the API; they are test messages. > > Can you rename them to progressAt0Percent and progressAt100Percent or something? > That would make it seem less like an actual API message (especially if we later > decide to add onPageCollapsed and onPageExpanded messages to the API; then it > could get really confusing). Done.
	8 else if (progress == 1)

	9 chrome.test.sendMessage('onPageExpanded');

	10 })

	11

5 chrome.test.sendMessage('Launched');	12 chrome.test.sendMessage('Launched');

OLD	NEW

« chrome/browser/apps/custom_launcher_page_browsertest_views.cc ('K') | « chrome/common/extensions/api/schemas.gypi ('k') | ui/app_list/app_list_model.h » ('j') | ui/app_list/views/contents_view.cc » ('J')

Powered by Google App Engine

This is Rietveld 408576698