chrome/test/data/extensions/platform_apps/custom_launcher_page/main.js - Issue 683703002: Notify launcher page with onTransitionChanged event - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(331)

My Issues | Starred Open | Closed | All

Side by Side Diff: chrome/test/data/extensions/platform_apps/custom_launcher_page/main.js

Issue 683703002: Notify launcher page with onTransitionChanged event (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@launcher_page_api_show_state_notify

Patch Set: nullptr like it's 1999 Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/common/extensions/api/launcher_page_private.idl ('K') | « chrome/common/extensions/api/schemas.gypi ('k') | ui/app_list/app_list_model.h » ('j') | ui/app_list/app_list_model.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

	5 chrome.launcherPagePrivate.onTransitionChanged.addListener(function(progress) {
	Matt Giuca 2014/11/03 00:57:42 Same here... doesn't seem updated to the new API. Same here... doesn't seem updated to the new API. calamity 2014/11/06 02:36:32 It has. onTransitionChanged is the new API. The co Show quoted text On 2014/11/03 00:57:42, Matt Giuca wrote: > Same here... doesn't seem updated to the new API. It has. onTransitionChanged is the new API. The code below then sends a message on 0 and on 1 which represent the fully collapsed and fully expanded states.
	6 if (progress == 0)

	7 chrome.test.sendMessage('onPageCollapsed');

	8 else if (progress == 1)

	9 chrome.test.sendMessage('onPageExpanded');

	10 })

	11

5 chrome.test.sendMessage('Launched');	12 chrome.test.sendMessage('Launched');

OLD	NEW

« chrome/common/extensions/api/launcher_page_private.idl ('K') | « chrome/common/extensions/api/schemas.gypi ('k') | ui/app_list/app_list_model.h » ('j') | ui/app_list/app_list_model.h » ('J')

Powered by Google App Engine

This is Rietveld 408576698