chrome/common/extensions/api/launcher_page_private.idl - Issue 683703002: Notify launcher page with onTransitionChanged event

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/extensions/api/launcher_page_private.idl

Issue 683703002: Notify launcher page with onTransitionChanged event (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@launcher_page_api_show_state_notify

Patch Set: nullptr like it's 1999 Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/common/extensions/api/_api_features.json ('K') | « chrome/common/extensions/api/_api_features.json ('k') | chrome/common/extensions/api/schemas.gypi » ('j') | chrome/test/data/extensions/platform_apps/custom_launcher_page/main.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // The <code>chrome.launcherPagePrivate</code> API provides launcher pages in

	6 // the App Launcher with the capabilities and events they need.

	7 namespace launcherPagePrivate {

	8 interface Events {

	9 static void onTransitionChanged(double progress);
	tapted 2014/11/03 00:31:20 What's the long-term plan for `progress`? In the c What's the long-term plan for `progress`? In the current form, it looks like you could just observe via `document.addEventListener('visibilitychange', function() {..}` (and if that's not working properly for the custom launcher pages then it should be fixed). Matt Giuca 2014/11/03 00:57:42 Where do you introduce the ability for JS code to Where do you introduce the ability for JS code to subscribe to this event? Is it all automatic? I think all of this API stuff should also be split up into a separate CL (so you introduce all the IDL and the API itself, but the event never receives any calls until this follow-up CL). calamity 2014/11/06 02:36:31 progress is used for touch events which will requi Show quoted text On 2014/11/03 00:31:20, tapted wrote: > What's the long-term plan for `progress`? In the current form, it looks like you > could just observe via `document.addEventListener('visibilitychange', function() > {..}` (and if that's not working properly for the custom launcher pages then it > should be fixed). progress is used for touch events which will require constant updates. calamity 2014/11/06 02:36:31 Yes. It's all automatic. I'll split it after anoth Show quoted text On 2014/11/03 00:57:42, Matt Giuca wrote: > Where do you introduce the ability for JS code to subscribe to this event? Is it > all automatic? > > I think all of this API stuff should also be split up into a separate CL (so you > introduce all the IDL and the API itself, but the event never receives any calls > until this follow-up CL). Yes. It's all automatic. I'll split it after another review round.
	10 };

	11 };

OLD	NEW