Issue 6837021: Disable bookmark editing (views UI).

Issue 6837021: Disable bookmark editing (views UI). (Closed)

Created:
9 years, 8 months ago by Joao da Silva

Modified:
9 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Disable bookmark editing (views UI). BUG=49604 TEST=Set the EditBookmarksEnabled policy to false. Modifying bookmarks from the views UI shouldn't be possible. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81419

Patch Set 1 #

Total comments: 6

Patch Set 2 : Rebase. #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -18 lines)			Patch
M	chrome/browser/bookmarks/bookmark_utils.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/bookmarks/bookmark_utils.cc	View		1 chunk	+6 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_views.cc	View		3 chunks	+11 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.cc	View	1	3 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/location_bar/location_bar_view.h	View	1	4 chunks	+11 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/location_bar/location_bar_view.cc	View	1	4 chunks	+16 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Joao da Silva

Hi Scott, can you review this please? I picked you as a reviewer because browser/ui/views/bookmarks/OWNERS ...

9 years, 8 months ago (2011-04-13 13:07:10 UTC) #1

sky

LGTM http://codereview.chromium.org/6837021/diff/1/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc File chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc (right): http://codereview.chromium.org/6837021/diff/1/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc#newcode544 chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc:544: if (!profile_->GetPrefs()->GetBoolean(prefs::kEditBookmarksEnabled)) Combine with previous if. http://codereview.chromium.org/6837021/diff/1/chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.cc File ...

9 years, 8 months ago (2011-04-13 14:28:55 UTC) #2

Joao da Silva

9 years, 8 months ago (2011-04-13 14:42:42 UTC) #3

Thanks for reviewing! Waiting for bot approval before committing.

http://codereview.chromium.org/6837021/diff/1/chrome/browser/ui/views/bookmar...
File chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc (right):

http://codereview.chromium.org/6837021/diff/1/chrome/browser/ui/views/bookmar...
chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc:544: if
(!profile_->GetPrefs()->GetBoolean(prefs::kEditBookmarksEnabled))
On 2011/04/13 14:28:55, sky wrote:
> Combine with previous if.

Done.

http://codereview.chromium.org/6837021/diff/1/chrome/browser/ui/views/bookmar...
File chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.cc
(right):

http://codereview.chromium.org/6837021/diff/1/chrome/browser/ui/views/bookmar...
chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.cc:142: if
(!profile_->GetPrefs()->GetBoolean(prefs::kEditBookmarksEnabled))
On 2011/04/13 14:28:55, sky wrote:
> Combine with previous if

Done.

http://codereview.chromium.org/6837021/diff/1/chrome/browser/ui/views/locatio...
File chrome/browser/ui/views/location_bar/location_bar_view.cc (right):

http://codereview.chromium.org/6837021/diff/1/chrome/browser/ui/views/locatio...
chrome/browser/ui/views/location_bar/location_bar_view.cc:1196: if (*name ==
prefs::kEditBookmarksEnabled) {
On 2011/04/13 14:28:55, sky wrote:
> nit: no {}

Done.

Expand Messages | Collapse Messages