Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 683693003: Remove unnecessary check in IsSystemRealTimeMessage. (Closed)

Created:
6 years, 1 month ago by Ben Chan
Modified:
6 years, 1 month ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, Chris Masone
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary check in IsSystemRealTimeMessage. The 'data <= 0xff' check in IsSystemRealTimeMessage is unnecessary as |data| is a uint8 integer. This CL removes the check to prevent the following compilation error when building with '-Werror=type-limits'. ../../media/midi/midi_message_queue.cc: In function 'bool media::{anonymous}::IsSystemRealTimeMessage(uint8)': ../../media/midi/midi_message_queue.cc:27:34: error: comparison is always true due to limited range of data type [-Werror=type-limits] return 0xf8 <= data && data <= 0xff; ^ BUG=424334, 427726 TEST=Build successfully with '-Werror=type-limits' using the GN flow. Committed: https://crrev.com/4454938c07fd3d03112d0faae956f2fe47fc58be Cr-Commit-Position: refs/heads/master@{#301803}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M media/midi/midi_message_queue.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Ben Chan
6 years, 1 month ago (2014-10-29 00:08:46 UTC) #3
yhirano
lgtm
6 years, 1 month ago (2014-10-29 01:40:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/683693003/1
6 years, 1 month ago (2014-10-29 06:32:57 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-29 07:24:29 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-10-29 07:25:07 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4454938c07fd3d03112d0faae956f2fe47fc58be
Cr-Commit-Position: refs/heads/master@{#301803}

Powered by Google App Engine
This is Rietveld 408576698