Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 683623003: Add more WeakPtr checks for SurfaceFactory in SurfaceAggregator. (Closed)

Created:
6 years, 1 month ago by jbauman
Modified:
6 years, 1 month ago
Reviewers:
jamesr
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add more WeakPtr checks for SurfaceFactory in SurfaceAggregator. With DestroyOnSequence, a Surface can live long after its SurfaceFactory dies, so every use of the SurfaceFactory needs to check whether it still exists. Committed: https://crrev.com/84c27fac01d5cb35c80abf59cf3b6f2ecbf2fc22 Cr-Commit-Position: refs/heads/master@{#301572}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M cc/surfaces/surface_aggregator.cc View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jbauman
6 years, 1 month ago (2014-10-28 01:55:24 UTC) #2
jamesr
lgtm
6 years, 1 month ago (2014-10-28 04:56:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/683623003/1
6 years, 1 month ago (2014-10-28 05:08:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-28 06:07:18 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 06:08:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/84c27fac01d5cb35c80abf59cf3b6f2ecbf2fc22
Cr-Commit-Position: refs/heads/master@{#301572}

Powered by Google App Engine
This is Rietveld 408576698