Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Unified Diff: sky/engine/bindings/templates/interface.cpp

Issue 683593002: Remove GarbageCollected support from the bindings (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/bindings/templates/interface.h ('k') | sky/engine/bindings/templates/interface_base.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/bindings/templates/interface.cpp
diff --git a/sky/engine/bindings/templates/interface.cpp b/sky/engine/bindings/templates/interface.cpp
index f48d54db4e8fc441cb51311924ce32fb88111005..3dd28364e55e021740371a0e5cb3a1d11351333c 100644
--- a/sky/engine/bindings/templates/interface.cpp
+++ b/sky/engine/bindings/templates/interface.cpp
@@ -497,7 +497,7 @@ static void {{cpp_class}}OriginSafeMethodSetterCallback(v8::Local<v8::String> na
if is_active_dom_object else '0' %}
{% set to_event_target = '%s::toEventTarget' % v8_class
if is_event_target else '0' %}
-const WrapperTypeInfo {{v8_class}}Constructor::wrapperTypeInfo = { gin::kEmbedderBlink, {{v8_class}}Constructor::domTemplate, {{v8_class}}::refObject, {{v8_class}}::derefObject, {{v8_class}}::createPersistentHandle, {{to_active_dom_object}}, {{to_event_target}}, 0, {{v8_class}}::installConditionallyEnabledMethods, {{v8_class}}::installConditionallyEnabledProperties, 0, WrapperTypeInfo::WrapperTypeObjectPrototype, WrapperTypeInfo::{{wrapper_class_id}}, WrapperTypeInfo::{{lifetime}}, WrapperTypeInfo::{{gc_type}} };
+const WrapperTypeInfo {{v8_class}}Constructor::wrapperTypeInfo = { gin::kEmbedderBlink, {{v8_class}}Constructor::domTemplate, {{v8_class}}::refObject, {{v8_class}}::derefObject, {{to_active_dom_object}}, {{to_event_target}}, 0, {{v8_class}}::installConditionallyEnabledMethods, {{v8_class}}::installConditionallyEnabledProperties, 0, WrapperTypeInfo::WrapperTypeObjectPrototype, WrapperTypeInfo::{{wrapper_class_id}}, WrapperTypeInfo::{{lifetime}} };
{{generate_constructor(named_constructor)}}
v8::Handle<v8::FunctionTemplate> {{v8_class}}Constructor::domTemplate(v8::Isolate* isolate)
@@ -1208,41 +1208,12 @@ v8::Handle<v8::Object> {{v8_class}}::createWrapper({{pass_cpp_type}} impl, v8::H
void {{v8_class}}::refObject(ScriptWrappableBase* internalPointer)
{
-{% if gc_type == 'WillBeGarbageCollectedObject' %}
-#if !ENABLE(OILPAN)
fromInternalPointer(internalPointer)->ref();
-#endif
-{% elif gc_type == 'RefCountedObject' %}
- fromInternalPointer(internalPointer)->ref();
-{% endif %}
}
void {{v8_class}}::derefObject(ScriptWrappableBase* internalPointer)
{
-{% if gc_type == 'WillBeGarbageCollectedObject' %}
-#if !ENABLE(OILPAN)
fromInternalPointer(internalPointer)->deref();
-#endif
-{% elif gc_type == 'RefCountedObject' %}
- fromInternalPointer(internalPointer)->deref();
-{% endif %}
-}
-
-WrapperPersistentNode* {{v8_class}}::createPersistentHandle(ScriptWrappableBase* internalPointer)
-{
-{% if gc_type == 'GarbageCollectedObject' %}
- return new WrapperPersistent<{{cpp_class}}>(fromInternalPointer(internalPointer));
-{% elif gc_type == 'WillBeGarbageCollectedObject' %}
-#if ENABLE(OILPAN)
- return new WrapperPersistent<{{cpp_class}}>(fromInternalPointer(internalPointer));
-#else
- ASSERT_NOT_REACHED();
- return 0;
-#endif
-{% elif gc_type == 'RefCountedObject' %}
- ASSERT_NOT_REACHED();
- return 0;
-{% endif %}
}
template<>
« no previous file with comments | « sky/engine/bindings/templates/interface.h ('k') | sky/engine/bindings/templates/interface_base.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698