sky/engine/bindings/scripts/v8_utilities.py - Issue 683593002: Remove GarbageCollected support from the bindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/bindings/scripts/v8_utilities.py

Issue 683593002: Remove GarbageCollected support from the bindings (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/bindings/scripts/v8_utilities.py

diff --git a/sky/engine/bindings/scripts/v8_utilities.py b/sky/engine/bindings/scripts/v8_utilities.py

index 53f305819ba66744b40cbcaa3252326c6668536f..61e144043f0cba1a4a49d1e3810cb3e7f39a7e52 100644

--- a/sky/engine/bindings/scripts/v8_utilities.py

+++ b/sky/engine/bindings/scripts/v8_utilities.py

@@ -269,16 +269,6 @@ def expanded_exposure_set_for_interface(interface):

return sorted(set(exposure_set))

-# [GarbageCollected], [WillBeGarbageCollected]

-def gc_type(definition):

- extended_attributes = definition.extended_attributes

- if 'GarbageCollected' in extended_attributes:

- return 'GarbageCollectedObject'

- elif 'WillBeGarbageCollected' in extended_attributes:

- return 'WillBeGarbageCollectedObject'

- return 'RefCountedObject'

# [ImplementedAs]

def cpp_name(definition_or_member):

extended_attributes = definition_or_member.extended_attributes

« no previous file with comments | « sky/engine/bindings/scripts/v8_types.py ('k') | sky/engine/bindings/templates/interface.h » ('j') | no next file with comments »