Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: sky/engine/bindings/scripts/v8_interface.py

Issue 683593002: Remove GarbageCollected support from the bindings (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/bindings/scripts/v8_interface.py
diff --git a/sky/engine/bindings/scripts/v8_interface.py b/sky/engine/bindings/scripts/v8_interface.py
index 7fed1f06644809c08fc0ecc3684da023ccca8b01..3638ac4fa6d78ac8c4afb0e314a836120b2c6112 100644
--- a/sky/engine/bindings/scripts/v8_interface.py
+++ b/sky/engine/bindings/scripts/v8_interface.py
@@ -44,9 +44,9 @@ import v8_attributes
from v8_globals import includes
import v8_methods
import v8_types
-from v8_types import cpp_ptr_type, cpp_template_type
+from v8_types import cpp_template_type
import v8_utilities
-from v8_utilities import (capitalize, conditional_string, cpp_name, gc_type,
+from v8_utilities import (capitalize, conditional_string, cpp_name,
has_extended_attribute_value, runtime_enabled_function_name,
extended_attribute_value_as_list)
@@ -151,14 +151,11 @@ def interface_context(interface):
reachable_node_function or
set_wrapper_reference_to_list)
- this_gc_type = gc_type(interface)
-
wrapper_class_id = ('NodeClassId' if inherits_interface(interface.name, 'Node') else 'ObjectClassId')
context = {
'conditional_string': conditional_string(interface), # [Conditional]
'cpp_class': cpp_name(interface),
- 'gc_type': this_gc_type,
# FIXME: Remove 'EventTarget' special handling, http://crbug.com/383699
'has_access_check_callbacks': (is_check_security and
interface.name != 'Window' and
@@ -186,7 +183,7 @@ def interface_context(interface):
'measure_as': v8_utilities.measure_as(interface), # [MeasureAs]
'parent_interface': parent_interface,
'pass_cpp_type': cpp_template_type(
- cpp_ptr_type('PassRefPtr', 'RawPtr', this_gc_type),
+ 'PassRefPtr',
cpp_name(interface)),
'reachable_node_function': reachable_node_function,
'runtime_enabled_function': runtime_enabled_function_name(interface), # [RuntimeEnabled]
@@ -893,7 +890,7 @@ def constructor_context(interface, constructor):
for index, argument in enumerate(constructor.arguments)],
'arguments_need_try_catch': arguments_need_try_catch,
'cpp_type': cpp_template_type(
- cpp_ptr_type('RefPtr', 'RawPtr', gc_type(interface)),
+ 'RefPtr',
cpp_name(interface)),
'cpp_value': v8_methods.cpp_value(
interface, constructor, len(constructor.arguments)),
« no previous file with comments | « sky/engine/bindings/scripts/compute_interfaces_info_overall.py ('k') | sky/engine/bindings/scripts/v8_methods.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698