Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 683543002: cc: Make picture pile base thread safe. (Closed)

Created:
6 years, 1 month ago by vmpstr
Modified:
6 years, 1 month ago
Reviewers:
reveman
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: Make picture pile base thread safe. This patch ensures that picture pile base is thread safe, since it is not guaranteed that the ref is always adjusted on the same thread. In particular, the worker thread (which refs picture pile on the cc thread) might deref it (and delete it) on the worker thread. R=reveman Committed: https://crrev.com/e1601613e8f4b8cbe451fb37d99409b1da19b74a Cr-Commit-Position: refs/heads/master@{#301434}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M cc/resources/picture_pile_base.h View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
vmpstr
PTAL
6 years, 1 month ago (2014-10-27 19:39:05 UTC) #1
reveman
lgtm fyi, not just deref on a worker thread, but deref and delete the instance ...
6 years, 1 month ago (2014-10-27 19:42:10 UTC) #2
vmpstr
On 2014/10/27 19:42:10, reveman wrote: > lgtm > > fyi, not just deref on a ...
6 years, 1 month ago (2014-10-27 19:43:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/683543002/1
6 years, 1 month ago (2014-10-27 19:46:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-27 20:37:00 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 20:37:41 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e1601613e8f4b8cbe451fb37d99409b1da19b74a
Cr-Commit-Position: refs/heads/master@{#301434}

Powered by Google App Engine
This is Rietveld 408576698