Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: content/browser/renderer_host/media/midi_host_unittest.cc

Issue 68353002: Use MIDIMessageQueue/IsValidWebMIDIData for MIDI byte stream validation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed unnecessary notation from a header comment, to address scherkus' comment. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/renderer_host/media/midi_host.cc ('k') | content/content_tests.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/media/midi_host_unittest.cc
diff --git a/content/browser/renderer_host/media/midi_host_unittest.cc b/content/browser/renderer_host/media/midi_host_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..fedb4265b9bcb5ae2f11195928cb9458d77a8c20
--- /dev/null
+++ b/content/browser/renderer_host/media/midi_host_unittest.cc
@@ -0,0 +1,90 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/browser/renderer_host/media/midi_host.h"
+
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace content {
+namespace {
+
+const uint8 kGMOn[] = { 0xf0, 0x7e, 0x7f, 0x09, 0x01, 0xf7 };
+const uint8 kGSOn[] = {
+ 0xf0, 0x41, 0x10, 0x42, 0x12, 0x40, 0x00, 0x7f, 0x00, 0x41, 0xf7,
+};
+const uint8 kNoteOn[] = { 0x90, 0x3c, 0x7f };
+const uint8 kNoteOnWithRunningStatus[] = {
+ 0x90, 0x3c, 0x7f, 0x3c, 0x7f, 0x3c, 0x7f,
+};
+const uint8 kChannelPressure[] = { 0xd0, 0x01 };
+const uint8 kChannelPressureWithRunningStatus[] = {
+ 0xd0, 0x01, 0x01, 0x01,
+};
+const uint8 kTimingClock[] = { 0xf8 };
+const uint8 kBrokenData1[] = { 0x90 };
+const uint8 kBrokenData2[] = { 0xf7 };
+const uint8 kBrokenData3[] = { 0xf2, 0x00 };
+const uint8 kDataByte0[] = { 0x00 };
+
+template <typename T, size_t N>
+const std::vector<T> AsVector(const T(&data)[N]) {
+ std::vector<T> buffer;
+ buffer.insert(buffer.end(), data, data + N);
+ return buffer;
+}
+
+template <typename T, size_t N>
+void PushToVector(const T(&data)[N], std::vector<T>* buffer) {
+ buffer->insert(buffer->end(), data, data + N);
+}
+
+} // namespace
+
+TEST(MIDIHostTest, IsValidWebMIDIData) {
+ // Test single event scenario
+ EXPECT_TRUE(MIDIHost::IsValidWebMIDIData(AsVector(kGMOn)));
+ EXPECT_TRUE(MIDIHost::IsValidWebMIDIData(AsVector(kGSOn)));
+ EXPECT_TRUE(MIDIHost::IsValidWebMIDIData(AsVector(kNoteOn)));
+ EXPECT_TRUE(MIDIHost::IsValidWebMIDIData(AsVector(kChannelPressure)));
+ EXPECT_TRUE(MIDIHost::IsValidWebMIDIData(AsVector(kTimingClock)));
+ EXPECT_FALSE(MIDIHost::IsValidWebMIDIData(AsVector(kBrokenData1)));
+ EXPECT_FALSE(MIDIHost::IsValidWebMIDIData(AsVector(kBrokenData2)));
+ EXPECT_FALSE(MIDIHost::IsValidWebMIDIData(AsVector(kBrokenData3)));
+ EXPECT_FALSE(MIDIHost::IsValidWebMIDIData(AsVector(kDataByte0)));
+
+ // MIDI running status should be disallowed
+ EXPECT_FALSE(MIDIHost::IsValidWebMIDIData(
+ AsVector(kNoteOnWithRunningStatus)));
+ EXPECT_FALSE(MIDIHost::IsValidWebMIDIData(
+ AsVector(kChannelPressureWithRunningStatus)));
+
+ // Multiple messages are allowed as long as each of them is complete.
+ {
+ std::vector<uint8> buffer;
+ PushToVector(kGMOn, &buffer);
+ PushToVector(kNoteOn, &buffer);
+ PushToVector(kGSOn, &buffer);
+ PushToVector(kTimingClock, &buffer);
+ PushToVector(kNoteOn, &buffer);
+ EXPECT_TRUE(MIDIHost::IsValidWebMIDIData(buffer));
+ PushToVector(kBrokenData1, &buffer);
+ EXPECT_FALSE(MIDIHost::IsValidWebMIDIData(buffer));
+ }
+
+ // MIDI realtime message can be placed at any position.
+ {
+ const uint8 kNoteOnWithRealTimeClock[] = {
+ 0x90, 0xf8, 0x3c, 0x7f, 0x90, 0xf8, 0x3c, 0xf8, 0x7f, 0xf8,
+ };
+ EXPECT_TRUE(MIDIHost::IsValidWebMIDIData(
+ AsVector(kNoteOnWithRealTimeClock)));
+
+ const uint8 kGMOnWithRealTimeClock[] = {
+ 0xf0, 0xf8, 0x7e, 0x7f, 0x09, 0x01, 0xf8, 0xf7,
+ };
+ EXPECT_TRUE(MIDIHost::IsValidWebMIDIData(AsVector(kGMOnWithRealTimeClock)));
+ }
+}
+
+} // namespace conent
« no previous file with comments | « content/browser/renderer_host/media/midi_host.cc ('k') | content/content_tests.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698