Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 683473002: Fix ability to capture archives in webpages_playback.py (Closed)

Created:
6 years, 1 month ago by rmistry
Modified:
6 years, 1 month ago
Reviewers:
*borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Fix ability to capture archives in webpages_playback.py Updated all page sets to match the file name. This is to make it easier to call record_wpr with the page set class name. Also updated the wait time for baidu to 60 seconds. BUG=skia:3049 Committed: https://skia.googlesource.com/skia/+/7620bf06581aa36d8c478624eff240ff150f3bb7

Patch Set 1 : Initial upload #

Patch Set 2 : Cleanup #

Patch Set 3 : Increase baidu timeout #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -137 lines) Patch
M tools/skp/page_sets/skia_amazon_desktop.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_androidpolice_nexus10.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_baidu_desktop.py View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M tools/skp/page_sets/skia_blogger_desktop.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_booking_desktop.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_carsvg_desktop.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_chalkboard_desktop.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_cnet_nexus10.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_css3gradients_desktop.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_culturalsolutions_nexus10.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_cuteoverload_nexus10.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_deviantart_nexus10.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_digg_nexus10.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_ebay_desktop.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_engadget_nexus10.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_espn_desktop.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_facebook_desktop.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_fontwipe_desktop.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_forecastio_desktop.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_frantzen_nexus10.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_gamedeksiam_nexus10.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_gmail_nexus10.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_gmailthread_desktop.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_googleblog_nexus10.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_googlecalendar_nexus10.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_googlehome_desktop.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_googleplus_desktop.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_googlespreadsheet_desktop.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_googlespreadsheetdashed_desktop.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_gspro_nexus10.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_gws_desktop.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_hsfi_nexus10.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_jsfiddlebigcar_desktop.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_jsfiddlehumperclip_desktop.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_linkedin_desktop.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_mapsvg_desktop.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_mercurynews_nexus10.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_mlb_nexus10.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_mobilenews_desktop.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_mozilla_nexus10.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_nofolo_nexus10.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_nytimes_nexus10.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_oldinboxapp_desktop.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_pinterest_desktop.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_pokemonwiki_desktop.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_pravda_nexus10.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_rectangletransition_desktop.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_sahadan_nexus10.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_samoasvg_desktop.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_sfgate_desktop.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_slashdot_nexus10.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_techmeme_nexus10.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_tigersvg_desktop.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_twitter_desktop.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_ukwsj_nexus10.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_vnexpress_nexus10.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_weather_desktop.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_wikipedia_galaxynexus.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_worldjournal_nexus10.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_wowwiki_desktop.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_yahooanswers_desktop.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_youtube_desktop.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_youtubetvvideo_desktop.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skp/webpages_playback.py View 1 6 chunks +12 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
rmistry
6 years, 1 month ago (2014-10-27 13:16:22 UTC) #3
borenet
LGTM
6 years, 1 month ago (2014-10-27 13:32:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/683473002/40001
6 years, 1 month ago (2014-10-27 13:33:25 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 13:42:17 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as 7620bf06581aa36d8c478624eff240ff150f3bb7

Powered by Google App Engine
This is Rietveld 408576698