Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1090)

Issue 683463002: Do not call StackWindowFrontOf() when the AppActivity's window is already at the top (Closed)

Created:
6 years, 1 month ago by hashimoto
Modified:
6 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Do not call StackWindowFrontOf() when the AppActivity's window is already at the top BUG=427447 Committed: https://crrev.com/75ca683d501d4dc8277a95a833c09f101d1d3d9d Cr-Commit-Position: refs/heads/master@{#301560}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M athena/content/app_activity.cc View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
hashimoto
Stefan, could you review this small fix?
6 years, 1 month ago (2014-10-27 11:45:43 UTC) #2
Mr4D (OOO till 08-26)
lgtm
6 years, 1 month ago (2014-10-27 14:01:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/683463002/1
6 years, 1 month ago (2014-10-28 03:07:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-28 04:21:26 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 04:22:15 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/75ca683d501d4dc8277a95a833c09f101d1d3d9d
Cr-Commit-Position: refs/heads/master@{#301560}

Powered by Google App Engine
This is Rietveld 408576698