Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 683433004: Fix state checking of signalingState in peerconnection-call.html (Closed)

Created:
6 years, 1 month ago by tommi (sloooow) - chröme
Modified:
6 years, 1 month ago
Reviewers:
phoglund_chromium
CC:
chromium-reviews, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix state checking of signalingState in peerconnection-call.html and also create an answer when setting the remote description has completed. BUG=369796 Committed: https://crrev.com/61ac0d3b38dad4fc18935945395734522bdfa1ad Cr-Commit-Position: refs/heads/master@{#301425}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Improve error handling #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -7 lines) Patch
M content/test/data/media/peerconnection-call.html View 1 4 chunks +15 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
tommi (sloooow) - chröme
6 years, 1 month ago (2014-10-27 16:25:36 UTC) #2
phoglund_chromium
lgtm (one suggestion) https://codereview.chromium.org/683433004/diff/1/content/test/data/media/peerconnection-call.html File content/test/data/media/peerconnection-call.html (right): https://codereview.chromium.org/683433004/diff/1/content/test/data/media/peerconnection-call.html#newcode10 content/test/data/media/peerconnection-call.html:10: window.onerror = function() { This a ...
6 years, 1 month ago (2014-10-27 17:28:17 UTC) #3
tommi (sloooow) - chröme
Improve error handling
6 years, 1 month ago (2014-10-27 18:38:23 UTC) #4
tommi (sloooow) - chröme
On 2014/10/27 17:28:17, phoglund wrote: > lgtm (one suggestion) > > https://codereview.chromium.org/683433004/diff/1/content/test/data/media/peerconnection-call.html > File content/test/data/media/peerconnection-call.html ...
6 years, 1 month ago (2014-10-27 18:38:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/683433004/20001
6 years, 1 month ago (2014-10-27 18:41:25 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-27 20:06:25 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 20:07:11 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/61ac0d3b38dad4fc18935945395734522bdfa1ad
Cr-Commit-Position: refs/heads/master@{#301425}

Powered by Google App Engine
This is Rietveld 408576698