Integrate the Irregexp Regular Expression Engine.

runtime/vm/method_recognizer.h

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_METHOD_RECOGNIZER_H_
 #define VM_METHOD_RECOGNIZER_H_
 
 #include "vm/allocation.h"
 
 namespace dart {
@@ skipping 180 matching lines @@
   V(_StringBase, [], StringBaseCharAt, 1512210677)                             \
   V(_OneByteString, get:hashCode, OneByteString_getHashCode, 1111837929)       \
   V(_OneByteString, _substringUncheckedNative,                                 \
       OneByteString_substringUnchecked, 1527498975)                            \
   V(_OneByteString, _setAt, OneByteStringSetAt, 468605749)                     \
   V(_OneByteString, _allocate, OneByteString_allocate, 2035417022)             \
   V(_OneByteString, ==, OneByteString_equality, 1727047023)                    \
   V(_TwoByteString, ==, TwoByteString_equality, 951149689)                     \
 
 
+// TODO(zerny): Remove this list and add _ExecuteMatch to
+// CORE_LIB_INTRINSIC_LIST once JSCRE has been removed.
+#define CORE_REGEXP_LIB_INTRINSIC_LIST(V)                                      \

[Ivan Posva, 2014/11/24 06:49:02]

Is this special handling still needed now that the intrinsifier properly deals
with JSCRE being enabled?

[zerny-google, 2014/11/24 13:07:03]

Not needed any more. Folded it into CORE_LIB_INTRINSIC_LIST.

+  V(_JSSyntaxRegExp, _ExecuteMatch, JSRegExp_ExecuteMatch, 1654250896)
+
+
 #define CORE_INTEGER_LIB_INTRINSIC_LIST(V)                                     \
   V(_IntegerImplementation, _addFromInteger, Integer_addFromInteger,           \
     438687793)                                                                 \
   V(_IntegerImplementation, +, Integer_add, 501253666)                         \
   V(_IntegerImplementation, _subFromInteger, Integer_subFromInteger,           \
     562800077)                                                                 \
   V(_IntegerImplementation, -, Integer_sub, 1819430179)                        \
   V(_IntegerImplementation, _mulFromInteger, Integer_mulFromInteger,           \
     67891834)                                                                  \
   V(_IntegerImplementation, *, Integer_mul, 1787870724)                        \
@@ skipping 82 matching lines @@
   GRAPH_CORE_INTRINSICS_LIST(V)                                                \
   GRAPH_TYPED_DATA_INTRINSICS_LIST(V)                                          \
 
 #define PROFILER_LIB_INTRINSIC_LIST(V)                                         \
   V(_UserTag, makeCurrent, UserTag_makeCurrent, 370414636)                     \
   V(::, _getDefaultTag, UserTag_defaultTag, 1159885970)                        \
   V(::, _getCurrentTag, Profiler_getCurrentTag, 1182126114)                    \
 
 #define ALL_INTRINSICS_NO_INTEGER_LIB_LIST(V)                                  \
   CORE_LIB_INTRINSIC_LIST(V)                                                   \
+  CORE_REGEXP_LIB_INTRINSIC_LIST(V)                                            \
   MATH_LIB_INTRINSIC_LIST(V)                                                   \
   TYPED_DATA_LIB_INTRINSIC_LIST(V)                                             \
   PROFILER_LIB_INTRINSIC_LIST(V)
 
 #define ALL_INTRINSICS_LIST(V)                                                 \
   ALL_INTRINSICS_NO_INTEGER_LIB_LIST(V)                                        \
   CORE_INTEGER_LIB_INTRINSIC_LIST(V)
 
 #define RECOGNIZED_LIST(V)                                                     \
   OTHER_RECOGNIZED_LIST(V)                                                     \
   ALL_INTRINSICS_LIST(V)                                                       \
   GRAPH_INTRINSICS_LIST(V)
 
 // A list of core function that should always be inlined.
 #define INLINE_WHITE_LIST(V)                                                   \
   V(Object, ==, ObjectEquals, 1068471689)                                      \
   V(_List, get:length, ObjectArrayLength, 1181352729)                          \
   V(_ImmutableList, get:length, ImmutableArrayLength, 274917727)               \
   V(_TypedList, get:length, TypedDataLength, 522565357)                        \
   V(_GrowableList, get:length, GrowableArrayLength, 778505107)                 \
   V(_StringBase, get:length, StringBaseLength, 784399628)                      \
+  V(_GrowableList, add, GrowableListAdd, 1899133961)                           \
+  V(_GrowableList, removeLast, GrowableListRemoveLast, 1274907639)             \
   V(ListIterator, moveNext, ListIteratorMoveNext, 210829138)                   \
   V(_FixedSizeArrayIterator, moveNext, FixedListIteratorMoveNext, 1147271335)  \
   V(_GrowableList, get:iterator, GrowableArrayIterator, 1812933946)            \
   V(_GrowableList, forEach, GrowableArrayForEach, 2085943947)                  \
   V(_List, ., ObjectArrayAllocate, 1595327584)                                 \
   V(_List, [], ObjectArrayGetIndexed, 795612476)                               \
   V(_List, []=, ObjectArraySetIndexed, 1288827575)                             \
   V(_List, get:isEmpty, ObjectArrayIsEmpty, 2130247737)                        \
   V(_List, get:iterator, ObjectArrayIterator, 458612415)                       \
   V(_List, forEach, ObjectArrayForEach, 592525445)                             \
@@ skipping 97 matching lines @@
   static Kind RecognizeKind(const Function& function);
   static bool AlwaysInline(const Function& function);
   static bool PolymorphicTarget(const Function& function);
   static const char* KindToCString(Kind kind);
   static void InitializeState();
 };
 
 }  // namespace dart
 
 #endif  // VM_METHOD_RECOGNIZER_H_