tests/corelib/corelib.status - Issue 683433003: Integrate the Irregexp Regular Expression Engine.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tests/corelib/corelib.status

Issue 683433003: Integrate the Irregexp Regular Expression Engine. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: more comments Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« runtime/vm/intrinsifier_ia32.cc ('K') | « tests/co19/co19-runtime.status ('k') | no next file » | no next file with comments »

OLD	NEW
1 # Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file	1 # Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file

2 # for details. All rights reserved. Use of this source code is governed by a	2 # for details. All rights reserved. Use of this source code is governed by a

3 # BSD-style license that can be found in the LICENSE file.	3 # BSD-style license that can be found in the LICENSE file.

4	4

5 [ $compiler == dart2dart]	5 [ $compiler == dart2dart]

6 bool_from_environment2_test: Skip	6 bool_from_environment2_test: Skip

7 bool_from_environment_default_value_test: Skip	7 bool_from_environment_default_value_test: Skip

8 bool_from_environment_test: Skip	8 bool_from_environment_test: Skip

9 from_environment_const_type_test: Skip	9 from_environment_const_type_test: Skip

10 from_environment_const_type_undefined_test: Skip	10 from_environment_const_type_undefined_test: Skip

(...skipping 203 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
214 num_clamp_test: StaticWarning, OK # Test generates errors on purpose.	214 num_clamp_test: StaticWarning, OK # Test generates errors on purpose.

215 string_test: StaticWarning, OK # Test generates error on purpose.	215 string_test: StaticWarning, OK # Test generates error on purpose.

216	216

217 [ $runtime == ie10 ]	217 [ $runtime == ie10 ]

218 num_parse_test: RuntimeError # Issue 15316	218 num_parse_test: RuntimeError # Issue 15316

219 num_parse_test/01: RuntimeError # Issue 15316	219 num_parse_test/01: RuntimeError # Issue 15316

220	220

221 [ $system == windows && $arch == x64 ]	221 [ $system == windows && $arch == x64 ]

222 stopwatch_test: Skip # Flaky test due to expected performance behaviour.	222 stopwatch_test: Skip # Flaky test due to expected performance behaviour.

223	223

224 [ $runtime != d8 ]	224 [ $runtime != d8 && $runtime != vm ]

225 # JSCRE does not pass all of the tests ported for irregexp.	225 # JSCRE does not pass all of the tests ported for irregexp.
	Ivan Posva 2014/11/14 08:42:50 Comment is slightly wrong as JSCRE is not going to Comment is slightly wrong as JSCRE is not going to be a thing. zerny-google 2014/11/14 12:18:57 Rephrased to: # Ignore the regexp tests on runtim Show quoted text On 2014/11/14 08:42:50, Ivan Posva wrote: > Comment is slightly wrong as JSCRE is not going to be a thing. Rephrased to: # Ignore the regexp tests on runtimes without irregexp. as I think dartium would still be using jscre until they roll a new VM, no? Ivan Posva 2014/11/24 06:49:01 Dartium builds with TOT bleeding edge VMs, so it s Show quoted text On 2014/11/14 12:18:57, zerny-google wrote: > On 2014/11/14 08:42:50, Ivan Posva wrote: > > Comment is slightly wrong as JSCRE is not going to be a thing. > > Rephrased to: > > # Ignore the regexp tests on runtimes without irregexp. > > as I think dartium would still be using jscre until they roll a new VM, no? Dartium builds with TOT bleeding edge VMs, so it should have the same capability as the standalone VM.
226 # Ignore all of the tests until irregexp is fully ported.	226 # Ignore all of the tests until irregexp is fully ported.

227 regexp/*: Skip	227 regexp/*: Skip

OLD	NEW