Integrate the Irregexp Regular Expression Engine.

runtime/vm/intrinsifier.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 // Class for intrinsifying functions.
 
 #include "vm/assembler.h"
 #include "vm/intrinsifier.h"
 #include "vm/flags.h"
 #include "vm/object.h"
 #include "vm/symbols.h"
@@ skipping 51 matching lines @@
     }                                                                          \
     func = cls.LookupFunctionAllowPrivate(str);                                \
   }                                                                            \
   ASSERT(!func.IsNull());                                                      \
   func.set_is_intrinsic(true);
 
   // Set up all core lib functions that can be intrisified.
   lib = Library::CoreLibrary();
   ASSERT(!lib.IsNull());
   CORE_LIB_INTRINSIC_LIST(SETUP_FUNCTION);
+  if (FLAG_use_jscre) {
+    CORE_REGEXP_LIB_INTRINSIC_LIST(SETUP_FUNCTION);

[Ivan Posva, 2014/11/14 08:42:49]

Did you add an intrinsic for JSCRE?

[zerny-google, 2014/11/14 12:18:57]

Yes. So I missed this because it is not compatible with snapshotting. Slava
explained that the snapshot state can cause the the functions to-be/not-to-be
intrinsified regardless of the flag, so this flag can lead to an inconsistent
state. Instead I've removed the conditional and inserted early escapes in the
intrinsic bodies.

+  }
   CORE_INTEGER_LIB_INTRINSIC_LIST(SETUP_FUNCTION);
   GRAPH_CORE_INTRINSICS_LIST(SETUP_FUNCTION);
 
   // Set up all math lib functions that can be intrisified.
   lib = Library::MathLibrary();
   ASSERT(!lib.IsNull());
   MATH_LIB_INTRINSIC_LIST(SETUP_FUNCTION);
 
   // Set up all dart:typed_data lib functions that can be intrisified.
   lib = Library::TypedDataLibrary();
@@ skipping 478 matching lines @@
       new LoadFieldInstr(new Value(backing_store),
                          Array::length_offset(),
                          Type::ZoneHandle(),
                          builder.TokenPos()));
   builder.AddIntrinsicReturn(new Value(capacity));
   return true;
 }
 
 
 }  // namespace dart