Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Issue 68343015: Roll Skia DEPS to 12260 (Closed)

Created:
7 years, 1 month ago by robertphillips
Modified:
7 years, 1 month ago
Reviewers:
bsalomon, rmistry, reed1
CC:
chromium-reviews, skia-team_google.com
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Bisect to r12204 #

Patch Set 3 : Bisect to r12215 #

Patch Set 4 : bisect to r12224 #

Patch Set 5 : Trying the big hammer #

Patch Set 6 : Fix the big hammer #

Total comments: 2

Patch Set 7 : Roll to r12260 #

Patch Set 8 : Fix gyp file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M DEPS View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M skia/skia_common.gypi View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M skia/skia_library.gypi View 1 2 3 4 5 6 2 chunks +2 lines, -3 lines 0 comments Download
M skia/skia_library_opts.gyp View 2 3 4 5 6 7 6 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
robertphillips
7 years, 1 month ago (2013-11-12 19:27:58 UTC) #1
bungeman-skia
The nice thing about 'common' for defines is that you know it's going to work. ...
7 years, 1 month ago (2013-11-12 21:43:42 UTC) #2
robertphillips
https://codereview.chromium.org/68343015/diff/230001/skia/skia_library.gypi File skia/skia_library.gypi (right): https://codereview.chromium.org/68343015/diff/230001/skia/skia_library.gypi#newcode59 skia/skia_library.gypi:59: 'defines': [ On 2013/11/12 21:43:42, bungeman1 wrote: > Be ...
7 years, 1 month ago (2013-11-12 23:00:23 UTC) #3
robertphillips
control: https://codereview.chromium.org/70333005/
7 years, 1 month ago (2013-11-12 23:01:04 UTC) #4
robertphillips
7 years, 1 month ago (2013-11-13 01:01:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #8 manually as r234689.

Powered by Google App Engine
This is Rietveld 408576698