Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 683413003: Eager compile for debugging when debug is active. (Closed)

Created:
6 years, 1 month ago by Yang
Modified:
6 years, 1 month ago
Reviewers:
ulan
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Eager compile for debugging when debug is active. Scenario: On reload, Devtools restores previously set break points. At this point, since Devtools is already opened, all code is compiled with debug break slots. No break points exist yet, so we would lazily compile inner functions, even ones that cannot be compiled lazily without a context. So when we use Debug::FindSharedFunctionInfoInScript to find the break positions, those lazily compiled functions are skipped. By eagerly compiling when debug is active, we make sure that whenever Devtools is open, functions that cannot be compiled lazily without a context are always compiled with its outer function. R=ulan@chromium.org BUG=chromium:424142 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=24971

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M src/compiler.cc View 1 2 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 1 month ago (2014-10-29 08:48:35 UTC) #1
ulan
lgtm
6 years, 1 month ago (2014-10-29 08:51:08 UTC) #2
Yang
6 years, 1 month ago (2014-10-29 10:28:19 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as 24971 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698