Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 683413002: [unpacker] Add a disable flag for the new zip unpacker. (Closed)

Created:
6 years, 1 month ago by mtomasz
Modified:
6 years, 1 month ago
Reviewers:
Ilya Sherman, fukino
CC:
chromium-reviews, stevenjb+watch_chromium.org, asvitkine+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[unpacker] Add a disable flag for the new zip unpacker. This patch adds a flag to disable the new zip unpacker. Note, that this flag is not used yet. TEST=unit_tests: *AboutFlagsHistogramTest* BUG=427775 Committed: https://crrev.com/644ca400689094e521619420d84288cd3c554e43 Cr-Commit-Position: refs/heads/master@{#301998}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -4 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chromeos/chromeos_switches.h View 7 chunks +5 lines, -4 lines 0 comments Download
M chromeos/chromeos_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
mtomasz
@fukino: PTAL. Thanks!
6 years, 1 month ago (2014-10-29 03:50:38 UTC) #2
fukino
On 2014/10/29 03:50:38, mtomasz wrote: > @fukino: PTAL. Thanks! lgtm.
6 years, 1 month ago (2014-10-29 03:55:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/683413002/1
6 years, 1 month ago (2014-10-29 04:00:41 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/20812)
6 years, 1 month ago (2014-10-29 04:06:24 UTC) #7
mtomasz
@isherman: PTAL at IDL.
6 years, 1 month ago (2014-10-29 04:09:12 UTC) #9
mtomasz
On 2014/10/29 04:09:12, mtomasz wrote: > @isherman: PTAL at IDL. @isherman: Friendly ping.
6 years, 1 month ago (2014-10-30 00:26:23 UTC) #10
Ilya Sherman
histograms lgtm
6 years, 1 month ago (2014-10-30 00:45:41 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/683413002/1
6 years, 1 month ago (2014-10-30 00:48:29 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-30 00:51:51 UTC) #14
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 00:52:33 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/644ca400689094e521619420d84288cd3c554e43
Cr-Commit-Position: refs/heads/master@{#301998}

Powered by Google App Engine
This is Rietveld 408576698